ManifoldSubset: New methods declare_equal, equal_subsets, equal_subset_family

[mkoeppe]

Two subsets are equal if they are subsets of each other.

We add methods equal_subsets, equal_subset_family; and a method declare_equal to make two or more subsets equal.

We modify the method subset_poset and superset_poset to quotient out by equality.

Depends on #31727
Depends on #31732

CC: @egourgoulhon @mjungmath @tscrim

Component: manifolds

Author: Matthias Koeppe

Branch/Commit: fd4506a

Reviewer: Eric Gourgoulhon

Issue created by migration from https://trac.sagemath.org/ticket/31736

[mkoeppe]

Branch: u/mkoeppe/manifoldsubset__new_methods_declare_equal__equal_subsets__equal_subset_family

[mkoeppe]

Commit: c9fd9f7

[mkoeppe]

Last 10 new commits:

cec7fa2	ManifoldSubset.open_covers: Add option supersets; use it to fix is_empty
c40ec03	ManifoldSubset.open_cover_family: Add option supersets
a066387	Fix doctests
1b5e5ac	ManifoldSubset.declare_empty: Add plot
48b2700	src/sage/manifolds/subset.py: Remove unused import, make doctest stable by using 'sorted'
b4171c9	Merge #31732
b77e098	ManifoldSubsetFiniteFamily.from_subsets_or_families: New constructor
8051a21	ManifoldSubset.equal_subsets, equal_subset_family: New
06aedf8	ManifoldSubset.{subset,superset}_digraph: New option quotient; use it for {subset,superset}_poset
c9fd9f7	ManifoldSubset.declare_equal: New

[sagetrac-git]

Changed commit from c9fd9f7 to e06932b

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

1e6a055	is_empty, declare_nonempty, has_defined_points: Add doc, examples
e06932b	Merge #31732

[egourgoulhon]

comment:4

Shouldn't we have

    def equal_subset_family(self):
-        return ManifoldSubsetFiniteFamily(self.supersets())
+        return ManifoldSubsetFiniteFamily(self.equal_subsets())

[sagetrac-git]

Changed commit from e06932b to 93b8aa3

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

93b8aa3

ManifoldSubset.equal_subset_family: Fixup

[mkoeppe]

comment:6

Indeed, thanks for catching this.

[egourgoulhon]

comment:7

Another comment: your name should appear in the AUTHORS field of src/sage/manifolds/subset.py, and possibly in other files, like src/sage/manifolds/topological_submanifold.py; such a field should also be added to src/sage/manifolds/family.py.

[sagetrac-git]

Changed commit from 93b8aa3 to 5c7bb75

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

5c7bb75

src/sage/manifolds/{family,manifold,subset,differentiable/manifold,**/*_submanifold}.py: Update authors, copyright

[mkoeppe]

comment:9

(I used git blame -w --date=format:%Y src/sage/manifolds/manifold.py | sort -k2 to determine what copyright years to add.)

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

f244b87

ManifoldSubset.subset_digraph: Do not forget to include isolated vertices

[sagetrac-git]

Changed commit from 5c7bb75 to f244b87

[egourgoulhon]

Reviewer: Eric Gourgoulhon

[egourgoulhon]

comment:13

Replying to @mkoeppe:

(I used git blame -w --date=format:%Y src/sage/manifolds/manifold.py | sort -k2 to determine what copyright years to add.)

Thanks!

[mkoeppe]

comment:14

Thanks for reviewing!

[sagetrac-git]

Changed commit from f244b87 to fd4506a

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

359dde1	Merge branch 't/31727/manifoldsubset__add_methods_subset_family__superset_family__equal_subset_family__deprecate_method_list_of_subsets' into t/31732/manifoldsubset__new_methods_declare_empty__declare_nonempty__is_empty__has_defined_points__open_cover_family
fd4506a	Merge #31732

[mkoeppe]

comment:16

Merged updated #31732 to resolve merge conflict

[vbraun]

Changed branch from u/mkoeppe/manifoldsubset__new_methods_declare_equal__equal_subsets__equal_subset_family to fd4506a