PolyhedronFace: Make it a subclass of ConvexSet_closed

[mkoeppe]

... we only need to be careful with the method ambient_dim, which is the dimension of the polyhedron, not of the space.

So in this ticket we add to the API defined by ConvexSet_base:

• the method ambient, which is allowed to be a containing convex set, not necessarily a space,
• the method ambient_vector_space, which is always a vector space (even if ambient is only a free module).

Depends on #31919

CC: @kliem @jplab @tscrim

Component: geometry

Author: Matthias Koeppe

Branch/Commit: f02ca28

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/31959

[mkoeppe]

Branch: u/mkoeppe/polyhedronface__make_it_a_subclass_of_convexset_closed

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

8d77b3e

PolyhedronFace.is_relatively_open, is_compact: New, add doctests

[sagetrac-git]

Commit: 8d77b3e

[mkoeppe]

Author: Matthias Koeppe

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

6ba5d9c	ConvexSet_base.ambient_vector_space: New
e66448e	PolyhedronFace.contains, ConvexSet_base._test_contains: New

[sagetrac-git]

Changed commit from 8d77b3e to e66448e

[tscrim]

comment:7

Every function needs a doctest, even if they are just @abstract_method stubs. (This annoys me too at times, but it is the current policy. Although it is good for showing how an implementation should (or does) work.) One in particular is ConvexSet_base._test_contains needs a doctest (since it was added in e66448e).

[sagetrac-git]

Changed commit from e66448e to 1f7826d

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

1f7826d

ConvexSet_base._test_contains: Expand and add doctests

[sagetrac-git]

Changed commit from 1f7826d to 669cea3

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

142fb46	ConvexSet_base.codimension: Add doctest for alias 'codim'
30ebaf5	ConvexSet_base.ambient_dim, ambient_dimension: Fix doc
fcf2a32	fix coverage
6bef52b	ConvexSet_base._test_convex_set: Run the testsuite of relint
1448835	RelativeInterior.ambient, ambient_vector_space, is_universe: New
8ff6457	Polyhedron_base.interior: Handle the empty polyhedron correctly
148016f	Polyhedron_base.product: Add doctest for alias 'cartesian_product'
669cea3	Merge #31919

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

6ab5677	RelativeInterior.is_universe: New
c085d30	Polyhedron_base.interior: Handle the empty polyhedron correctly
686d0af	Polyhedron_base.product: Add doctest for alias 'cartesian_product'
2b1d108	Merge #31919

[sagetrac-git]

Changed commit from 669cea3 to 2b1d108

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

7323b10

ConvexSet_base._test_contains: Only test extension to AA for exact base rings

[sagetrac-git]

Changed commit from 2b1d108 to 7323b10

[sagetrac-git]

Changed commit from 7323b10 to 94e6858

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

94e6858

RelativeInterior.ambient, ambient_vector_space, is_universe: New

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

0c9bc94

ConvexSet_base: Add default implementations of ambient, ambient_dim; add doctests

[sagetrac-git]

Changed commit from 94e6858 to 0c9bc94

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

ce91e44

src/sage/geometry/relative_interior.py: Fix doctest output

[sagetrac-git]

Changed commit from 0c9bc94 to ce91e44

[tscrim]

Reviewer: Travis Scrimshaw

[tscrim]

comment:15

Green bot => positive review

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

afa67ab

ambient_vector_space docstring: Fix bad blocks

[sagetrac-git]

Changed commit from ce91e44 to afa67ab

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

f0e7c58

ambient_vector_space docstring: Fix bad blocks

[sagetrac-git]

Changed commit from afa67ab to f0e7c58

[sagetrac-git]

Changed commit from f0e7c58 to 200d967

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

200d967

ConvexSet_base.ambient doctest: Actually test the method

[tscrim]

comment:19

LGTM.

[mkoeppe]

comment:20

Thank you!

[kliem]

comment:21

Can you please remove the import of SageObject in face.py.

It's redundant now.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

f02ca28

src/sage/geometry/polyhedron/face.py: Remove unused import

[sagetrac-git]

Changed commit from 200d967 to f02ca28

[kliem]

comment:25

It was positive before and the unused import was the only complaint.

[mkoeppe]

comment:26

Thanks!

[vbraun]

Changed branch from u/mkoeppe/polyhedronface__make_it_a_subclass_of_convexset_closed to f02ca28