ConvexSet_base: Add methods an_element, some_elements

[mkoeppe]

Although subclasses of ConvexSet_base are not necessarily Parents, it will be useful for them to provide an_element and some_elements methods.

Depends on #31959

CC: @kliem @tscrim @yuan-zhou

Component: geometry

Author: Matthias Koeppe

Branch/Commit: 1744ffa

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/31990

[mkoeppe]

Dependencies: #31959

[mkoeppe]

Branch: u/mkoeppe/convexset_base__add_methods_an_element__some_elements

[mkoeppe]

Last 10 new commits:

6ab5677	RelativeInterior.is_universe: New
c085d30	Polyhedron_base.interior: Handle the empty polyhedron correctly
686d0af	Polyhedron_base.product: Add doctest for alias 'cartesian_product'
2b1d108	Merge #31919
7323b10	ConvexSet_base._test_contains: Only test extension to AA for exact base rings
94e6858	RelativeInterior.ambient, ambient_vector_space, is_universe: New
0c9bc94	ConvexSet_base: Add default implementations of ambient, ambient_dim; add doctests
7d3ae5c	Merge #31959
2b1040c	ConvexSet_base.{an_element,some_elements}, Polyhedron.some_elements, RelativeInterior.some_elements: New
a884517	PolyhedronFace.some_elements: New

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

Commit: a884517

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

ce91e44	src/sage/geometry/relative_interior.py: Fix doctest output
b19b3cc	Merge #31959

[sagetrac-git]

Changed commit from a884517 to b19b3cc

[tscrim]

Reviewer: Travis Scrimshaw

[tscrim]

comment:5

The only little quip I have is that generally in Sage some_elements() returns a list rather than an iterable. It might be good to be consistent about this.

[sagetrac-git]

Changed commit from b19b3cc to ed898e6

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

f0e7c58	ambient_vector_space docstring: Fix bad blocks
200d967	ConvexSet_base.ambient doctest: Actually test the method
1c2bef5	Merge #31959
ed898e6	ConvexSet_base.an_element, some_elements: Go through generator method `_some_elements_`, make some_elements return a list

[sagetrac-git]

Changed commit from ed898e6 to 7152e1f

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

b3ac0f3	ConvexSet_base.an_element, some_elements: Raise NotImplementedError if `_some_elements_` is NotImplemented
7152e1f	ConvexSet_base._test_contains: Test some_elements too

[tscrim]

comment:10

Thanks. Green bot => positive review.

[sagetrac-git]

Changed commit from 7152e1f to 1744ffa

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

f02ca28	src/sage/geometry/polyhedron/face.py: Remove unused import
1744ffa	Merge #31959

[mkoeppe]

comment:12

Patchbot is green modulo the unrelated sage.misc.package test failure.
Merged latest #31959 to get rid of pyflakes' report on an unused import.

[mkoeppe]

comment:13

Thanks for reviewing!

[vbraun]

Changed branch from u/mkoeppe/convexset_base__add_methods_an_element__some_elements to 1744ffa