gfan testsuite hangs on 32bit

[mkoeppe]

For example: tox -e docker-centos-7-i386-standard gfan never seems to terminate.

To check, use tox -e docker-centos-7-i386-standard gfan-build-deps, then run the built image with Docker. Then make gfan builds the package and hangs in the testsuite after printing:

gfan-0.6.2.p1] Running command:"cat <testsuite/0509IntegerGroebnerFan/input|./gfan _overintegers --groebnerFan |grep F_VECTOR>testsuite/0509IntegerGroebnerFan/outputNew"
[gfan-0.6.2.p1] Running command:"cat <testsuite/0510Minkowskisum/input|./gfan _minkowskisum --symmetry | grep -A1 F_VECTOR>testsuite/0510Minkowskisum/outputNew"
[gfan-0.6.2.p1] Running command:"cat <testsuite/0511FanHomology/input|./gfan _fanhomology -i testsuite/0511FanHomology/nonTopHomology.poly>testsuite/0511FanHomology/outputNew"
[gfan-0.6.2.p1] Running command:"cat <testsuite/0600ResultantFan/input|./gfan _resultantfan --vectorinput | grep F_VECTOR -A1>testsuite/0600ResultantFan/outputNew"
[gfan-0.6.2.p1] Running command:"cat <testsuite/0601ResultantFanSpecialised/input|./gfan _resultantfan --vectorinput --special| grep F_VECTOR -A1>testsuite/0601ResultantFanSpecialised/outputNew"
[gfan-0.6.2.p1] Running command:"cat <testsuite/0602ResultantFanProjection/input|./gfan _resultantfan --vectorinput --projection| grep F_VECTOR -A1>testsuite/0602ResultantFanProjection/outputNew"

Upstream: Reported upstream. No feedback yet.

CC: @dimpase

Component: packages: standard

Keywords: sdl

Author: Thierry Monteil

Branch/Commit: 54702a1

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/32088

[mkoeppe]

comment:1

As a workaround, #31585 disables the gfan testsuite in the Docker workflows.

[dimpase]

comment:2

this is not docker-specific, I tried this on a real 32-bit Ubuntu, it gets stuck at the same test.

[sagetrac-tmonteil]

Changed keywords from none to sdl

[sagetrac-tmonteil]

comment:4

I confirm this on 32bit qemu-lated VM.

[sagetrac-tmonteil]

comment:5

It might be a problem on our side somehow. I did not run my 32 build machinery for 2 years, and at those times, it seems gfan selftests passed without issue.

Also, note that at the beginning of the self-tests, there is some:

[gfan-0.6.2.p1] Running the test suite for gfan-0.6.2.p1...
[gfan-0.6.2.p1] ./gfan _test
[gfan-0.6.2.p1] rm: cannot remove 'GfAnTeMpTeStS': No such file or directory

[tornaria]

comment:6

There's a patch to fix the hang here: https://github.com/void-linux/void-packages/blob/2c5be10e5ede5ff7210c5c7d12fc0ec5bdf04223/srcpkgs/gfan/patches/fix-int64-for-32bit-archs.patch

Also note that testsuite/0009RenderStairCase fails on i686, we had to add '-ffloat-store' to fix that one. I don't know if that's relevant for sage.

[sagetrac-tmonteil]

Upstream: Not yet reported upstream; Will do shortly.

[sagetrac-tmonteil]

comment:8

@tornaria : is your patch reported upstream ?

[tornaria]

comment:9

Replying to @sagetrac-tmonteil:

@tornaria : is your patch reported upstream ?

I emailed jensen (email from https://math.au.dk/~jensen/software/gfan/gfan.html) on nov 21 but I never received a reply.

The bug is also fixed in debian https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=974558 and void linux void-linux/void-packages#34182.

[fchapoton]

comment:10

bump to 9.6

[sagetrac-tmonteil]

Branch: u/tmonteil/gfan_testsuite_hangs_on_32bit

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

561ed35

#32088 : add -ffloat-store flag to let gfan 0009RenderStairCase testuite pass on 32bit machines

[sagetrac-git]

Commit: 561ed35

[mkoeppe]

comment:14

You can re-enable testing it in the CI then, by reverting sagemath/sagetrac-mirror@eba0a9c

[sagetrac-tmonteil]

comment:15

I setup a 32bit VM to test that ticket: the patch fixes 0602ResultantFanProjection but the change in spkg-install.in does not fix 0009RenderStairCase.

[mkoeppe]

comment:16

I think you need to set CXXFLAGS

[sagetrac-git]

Changed commit from 561ed35 to 54702a1

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

6592da5	#32088 : CFLAGS -> CXXFLAGS
54702a1	#32088 : enable gfan testsuite in the CI

[sagetrac-tmonteil]

comment:18

Replying to @mkoeppe:

I think you need to set CXXFLAGS

Indeed, it worked.

[sagetrac-tmonteil]

Author: Thierry Monteil

[sagetrac-tmonteil]

Changed upstream from Not yet reported upstream; Will do shortly. to Reported upstream. No feedback yet.

[mkoeppe]

Reviewer: Matthias Koeppe

[mkoeppe]

comment:21

Tested with tox -e docker-debian-buster-i386-standard -- gfan, looking good

[vbraun]

Changed branch from u/tmonteil/gfan_testsuite_hangs_on_32bit to 54702a1