-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for coordinate changes in curve plots #32578
Labels
Milestone
Comments
New commits:
|
Commit: |
Reviewer: Travis Scrimshaw |
comment:2
LGTM. |
comment:3
Thank you for the review! |
Changed branch from public/manifolds/curve_plot-32578 to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In Sage 9.5.beta2, the following attempt to plot a cardioid fails:
This is because the curve
c
is known only in polar coordinates and no attempt is made to compute its expression in terms of Cartesian coordinates. Forcing the latter computation by e.g.before invoking
c.plot(chart=E.cartesian_coordinates())
makes things work.In the current ticket, the method
plot
is modified, so that the expression in the coordinates specified by the argumentchart
is computed by means ofContinuousMap.coord_functions
. Moreover, this simplifies significantly the code ofDifferentiableCurve.plot
.CC: @tscrim @mjungmath @mkoeppe
Component: manifolds
Keywords: curve, plot
Author: Eric Gourgoulhon
Branch/Commit:
5ac0f28
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/32578
The text was updated successfully, but these errors were encountered: