-
-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features and optional tags for sage modules provided by separate distributions #32614
Comments
comment:2
Currently optional tags can contain neither
New commits:
|
Commit: |
Author: Matthias Koeppe |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:11
Next round of stupid questions: How is this going to work? Are we doing to have to add many such markers to a lot of doctests? How will we as developers test which ones we need to add? |
comment:14
Still no hyphens allowed in |
comment:15
Replying to @jhpalmieri:
That's right -- this reflects the fact that our tags for optional packages use the spkg names, which use underscore, not dash. |
comment:16
Replying to @jhpalmieri:
Using |
comment:17
I'll update the documentation |
Dependencies: #30887 |
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
|
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Reviewer: John Palmieri, Travis Scrimshaw |
comment:25
John, any other comments? I think I am ready to set a positive review. |
comment:26
I am happy with it. Please go ahead with a positive review when you are ready. |
comment:28
Thanks for the review! |
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
|
Changed dependencies from #30887 to none |
Changed branch from u/mkoeppe/features_and_optional_tags_for_sage_subset_distributions to |
... so that we can start writing
# optional - sage.symbolic
and similar.We use it in #32432 (sagemath-polyhedra) to skip doctests that depend on
sage.graphs
,sage.combinat
,sage.rings.number_field
etc.CC: @kliem @jhpalmieri
Component: doctest framework
Author: Matthias Koeppe
Branch/Commit:
4558791
Reviewer: John Palmieri, Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/32614
The text was updated successfully, but these errors were encountered: