Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

givaro spkg-configure: Reject too new versions #33042

Closed
mkoeppe opened this issue Dec 18, 2021 · 19 comments
Closed

givaro spkg-configure: Reject too new versions #33042

mkoeppe opened this issue Dec 18, 2021 · 19 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 18, 2021

The linbox team has recently released new versions of their packages: givaro-4.2.0, fflas-ffpack-2.5.0, linbox-1.7.0, which some cutting-edge distributions are already shipping: https://repology.org/project/givaro/versions

Unfortunately our spkg-configure for givaro only checks a lower version bound, not an upper bound. We do not have an spkg-configure for linbox - that's #29631; so we try to build an old linbox with a new givaro, which fails (upstream does not support this).
Hence these new, incompatible releases retroactively break released Sage versions.

This leads to build errors in our linbox spkg, such as

A workaround for users of released versions of Sage is to use ./configure --without-system-givaro.

Depends on #32947

CC: @dimpase @orlitzky @ClementPernet @kiwifb @EmmanuelCharpentier @antonio-rojas

Component: build: configure

Author: Matthias Koeppe

Branch/Commit: 1da5d31

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/33042

@mkoeppe mkoeppe added this to the sage-9.5 milestone Dec 18, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 18, 2021

Author: Matthias Koeppe

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 18, 2021

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 18, 2021

Dependencies: #32947

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 18, 2021

New commits:

d2d73dcbuild/pkgs/givaro/spkg-configure.m4: Reject givaro >= 4.2.0

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 18, 2021

Commit: d2d73dc

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 18, 2021

Changed commit from d2d73dc to f8d5fa2

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 18, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

ab4fb99tox.ini: Add ubuntu-jammy, debian-bookworm, linuxmint-20.3, fedora-36
e51225a.github/workflows/tox*.yml: Remove debian-jessie, add ubuntu-jammy, debian-bookworm, linuxmint-20.3, fedora-36
ac47e7d.github/workflows/tox-gcc_spkg.yml: Remove
f8d5fa2Merge #32947

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 18, 2021

comment:7
tox -e docker-ubuntu-focal-standard -- config.status

correctly accept givaro 4.1.1

tox -e docker-debian-bookworm-standard -- config.status

correctly rejects givaro 4.2.0

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 19, 2021

comment:10

Let's get this in please.

@dimpase
Copy link
Member

dimpase commented Dec 20, 2021

comment:11
+    m4_pushdef([SAGE_GIVARO_LTVER])
     m4_popdef([SAGE_GIVARO_MINVER])

That should be popdef,
obviously.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 20, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

1da5d31build/pkgs/givaro/spkg-configure.m4: Fix typo

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 20, 2021

Changed commit from f8d5fa2 to 1da5d31

@dimpase
Copy link
Member

dimpase commented Dec 20, 2021

comment:14

looks good to me

@dimpase
Copy link
Member

dimpase commented Dec 20, 2021

Reviewer: Dima Pasechnik

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 20, 2021

comment:15

Thanks!

@vbraun
Copy link
Member

vbraun commented Dec 28, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants