Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions (macOS): Fix filtering of experimental packages #33140

Closed
mkoeppe opened this issue Jan 10, 2022 · 14 comments
Closed

GH Actions (macOS): Fix filtering of experimental packages #33140

mkoeppe opened this issue Jan 10, 2022 · 14 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 10, 2022

Filtering by $targets_pattern is broken, so the jobs for experimental packages do too much work.

see for example https://github.com/sagemath/sage/runs/4752780943?check_suite_focus=true, which was supposed to only build packages starting with 0-g, but TARGETS_OPTIONAL=scipoptsuite modular_decomposition awali gdb deformation cocoalib surf gambit libtheora lie gap3 valgrind qepcad.

We also update some tox.ini settings for macos.

CC: @dimpase @kliem

Component: porting

Author: Matthias Koeppe

Branch/Commit: 41ec3aa

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/33140

@mkoeppe mkoeppe added this to the sage-9.5 milestone Jan 10, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 10, 2022

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 10, 2022

New commits:

51191fe.github/workflows/tox.yml (local-macos): Fix filtering of experimental packages
12f88cf.github/workflows/tox.yml (local-macos): Group optional/experimental package builds into fewer jobs

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 10, 2022

Commit: 12f88cf

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 10, 2022

Author: Matthias Koeppe

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 12, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

49236ddtox.ini: Add local-macos-python3_pythonorg-python3.9 etc., refactor CONFIG_CONFIGURE_ARGS_1=...--with-python
1fcdc91tox.ini: Updates for macos and manylinux from #31396
41ec3aatox.ini: Reindent

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 12, 2022

Changed commit from 12f88cf to 41ec3aa

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 27, 2022

comment:5

Needs review

@slel
Copy link
Member

slel commented Jan 30, 2022

comment:6

Set milestone to sage-9.6 after Sage 9.5 release.

@slel slel modified the milestones: sage-9.5, sage-9.6 Jan 30, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 4, 2022

comment:7

Can we please get this in? It will make the portability suite faster.

@dimpase
Copy link
Member

dimpase commented Feb 4, 2022

comment:8

lgtm

@dimpase
Copy link
Member

dimpase commented Feb 4, 2022

Reviewer: Dima Pasechnik

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 4, 2022

comment:9

Thank you!

@vbraun
Copy link
Member

vbraun commented Feb 12, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants