Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a bug in multiple zeta values #33257

Closed
fchapoton opened this issue Jan 31, 2022 · 9 comments
Closed

fix a bug in multiple zeta values #33257

fchapoton opened this issue Jan 31, 2022 · 9 comments
Labels
c: algebra p: major / 3 t: bug
Milestone
sage-9.6

Comments

@fchapoton
Copy link
Contributor

about the simplify_full of the unit, that was zero..

Depends on #33102

CC: @videlec @tscrim

Component: algebra

Author: Frédéric Chapoton

Branch/Commit: 7ea8aea

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/33257
@fchapoton fchapoton added this to the sage-9.6 milestone Jan 31, 2022
@fchapoton
Copy link
Contributor Author

Commit: 7ea8aea

@fchapoton
Copy link
Contributor Author

New commits:

7229a19some details about shuffle of words and multizetas
ec60e55Merge branch 'u/chapoton/33102' in 9.5
7ea8aeafix a bug in multiple zeta values

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/33257

@tscrim
Copy link
Collaborator

tscrim commented Feb 1, 2022

comment:2

There is a _sum_of_monomials() method for ModulesWithBasis (which probably should be overwritten in CFM to take advantage of its internal data structure to avoid transient objects). I feel like it would be best to use that method for the product. Modulo that, LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Feb 1, 2022

comment:3

Replying to @tscrim:

which probably should be overwritten in CFM to take advantage of its internal data structure to avoid transient objects

This is now #33267.

@fchapoton
Copy link
Contributor Author

comment:4

Thanks Travis. note that only the trivial last commit belongs to the ticket here

@tscrim
Copy link
Collaborator

tscrim commented Feb 2, 2022

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Feb 2, 2022

comment:5

I don't want to revert #33102, but I guess I can do it on #33267.

@vbraun
Copy link
Member

vbraun commented Feb 16, 2022

Changed branch from u/chapoton/33257 to 7ea8aea

@vbraun vbraun closed this as completed in 20684fe Feb 16, 2022
@tscrim tscrim mentioned this issue Feb 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: algebra p: major / 3 t: bug
Projects
None yet
Milestone
sage-9.6
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton