Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New upstream for database_stein_watkins #33881

Open
mkoeppe opened this issue May 22, 2022 · 28 comments
Open

New upstream for database_stein_watkins #33881

mkoeppe opened this issue May 22, 2022 · 28 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented May 22, 2022

We create Python packages at https://github.com/sagemath/database_stein_watkins
that serve as the new upstream.

The actual files will be accessed via importlib.resources; actually the backport package importlib-resources, because Python 3.8 does not have files and as_file. Also we need the added support for package resources in namespace packages: the distributions database-stein-watkins-mini and database-stein-watkins-huge both share the namespace database_stein_watkins.

Currently database-stein-watkins-huge is only a placeholder. Whether we can publish the huge package to PyPI will depend on whether the size limit request at pypi/support#1946 is successful.

We use hatchling as the build system. It supports PEP 660 editable wheels and namespace packages. (flit_core is not suitable - it does not have support for resources in namespace packages.)

Part of Meta-ticket #30914: Create upstream repositories, pip-installable packages for database packages

CC: @williamstein

Component: packages: optional

Author: Matthias Koeppe

Branch/Commit: u/mkoeppe/new_upstream_for_database_stein_watkins @ fb43593

Issue created by migration from https://trac.sagemath.org/ticket/33881

@mkoeppe mkoeppe added this to the sage-9.7 milestone May 22, 2022
@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 22, 2022

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 22, 2022

New commits:

747a578build/pkgs/database_stein_watkins_mini: New upstream

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 22, 2022

Commit: 747a578

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 22, 2022

Changed commit from 747a578 to 7579cc4

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 22, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

b7e702ebuild/pkgs/database_stein_watkins_mini/package-version.txt: Bump patch level
9893d47src/sage/databases/stein_watkins.py: Change all # optional tags to database_stein_watkins_mini
7579cc4src/sage/databases/stein_watkins.py: Use importlib_resources instead of reading from SAGE_SHARE

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 22, 2022

Author: Matthias Koeppe

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 22, 2022

Changed commit from 7579cc4 to 0348bf8

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 22, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

0348bf8build/pkgs/database_stein_watkins: New upstream

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 22, 2022

Changed commit from 0348bf8 to e9cba6c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 22, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

e9cba6csrc/sage/databases/stein_watkins.py: Add a test that needs the huge package

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 22, 2022

comment:14

Editable installs do not work yet

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 22, 2022

comment:15

Now they work.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 22, 2022

Work Issues: Add spkgs for hatchling and its deps

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 22, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

8958108build/pkgs/hatchling: New

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 22, 2022

Changed commit from e9cba6c to 8958108

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 22, 2022

Changed work issues from Add spkgs for hatchling and its deps to Change spkg for hatchling to normal, add its deps

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 21, 2022

Changed commit from 8958108 to fb43593

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 21, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

d8e55c9build/pkgs/database_stein_watkins_mini: New upstream
f16d624build/pkgs/database_stein_watkins_mini/package-version.txt: Bump patch level
19b503bsrc/sage/databases/stein_watkins.py: Change all # optional tags to database_stein_watkins_mini
773b85bsrc/sage/databases/stein_watkins.py: Use importlib_resources instead of reading from SAGE_SHARE
33c60d4build/pkgs/database_stein_watkins: New upstream
fb43593src/sage/databases/stein_watkins.py: Add a test that needs the huge package

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 21, 2022

Changed work issues from Change spkg for hatchling to normal, add its deps to none

@mkoeppe

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant