Reduced charpoly for skew polynomials

[xcaruso]

This ticket implements the computation of the reduced characteristic polynomial of a Ore polynomial defined over a finite field.

CC: @kryzar @tscrim

Component: algebra

Author: Xavier Caruso

Branch/Commit: 7235c93

Reviewer: Travis Scrimshaw, Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/33999

[xcaruso]

Branch: u/caruso/reduced_charpoly

[xcaruso]

Author: Xavier Caruso

[xcaruso]

Commit: 5217fb6

[xcaruso]

New commits:

5217fb6

reduced characteristic polynomial

[tscrim]

comment:3

In the docstring, should it be "characteristic polynomial"? The "polynomial" is missing.

The .. SEEALSO:: :meth: blocks are not latex (both sides should be `).

Be careful of this change:

-                for k from deb <= k <= d by r:
+                for k in range(deb, d+1, r):

The C code might not be a simple for loop as I don't think Cython is smart enough to realize when the step is an integer.

Trivially for PEP8, can you remove the spaces around the list-comprehension brackets (i.e., [1 for x in L] instead of [ 1 for x in L ])?

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

d79cad9	Merge branch 'develop' into reduced_charpoly
849b203	small fixes

[sagetrac-git]

Changed commit from 5217fb6 to 849b203

[fchapoton]

comment:6

missing :: in the doc after

Hence it appears as a bivariate polynomial.

and typo "speciify"

[tscrim]

comment:7

Sorry, I never saw your update. Once you make the change Frédéric mentioned, then this will be a positive review.

[tscrim]

Reviewer: Travis Scrimshaw, Frédéric Chapoton

[sagetrac-git]

Changed commit from 849b203 to 7235c93

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

b30032d	Merge branch 'u/caruso/reduced_charpoly' of git://trac.sagemath.org/sage into reduced_charpoly
7235c93	typos

[fchapoton]

comment:9

good to go, feu vert

[vbraun]

Changed branch from u/caruso/reduced_charpoly to 7235c93