-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docstring markup in sage/schemes #34160
Comments
This comment has been minimized.
This comment has been minimized.
comment:2
my tentative, not checked New commits:
|
Branch: u/chapoton/34160 |
Commit: |
Author: Frédéric Chapoton |
comment:3
with #30448 merged:
|
Changed branch from u/chapoton/34160 to u/klee/34160 |
Changed commit from |
Changed branch from u/klee/34160 to public/34160 |
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
|
Commit: |
Reviewer: Kwankyu Lee, Matthias Koeppe |
Dependencies: #30448 |
comment:7
Sorry for messing up commit lists... Positive review when the ticket is ready for review :) |
comment:8
merging with #30448 is not necessary, and makes the ticket un-reviewable |
comment:9
Replying to @fchapoton:
Right. When I upload the last commit "Add - before th", I accidentally merged #30448 to the branch here.
If you set the ticket to "needs review" and is okay with the last commit, then I will give positive view. |
comment:10
In the last commit, only this is significant: diff --git a/src/sage/schemes/elliptic_curves/isogeny_class.py b/src/sage/schemes/elliptic_curves/isogeny_class.py
index 340a771..2178273 100644
--- a/src/sage/schemes/elliptic_curves/isogeny_class.py
+++ b/src/sage/schemes/elliptic_curves/isogeny_class.py
@@ -97,7 +97,7 @@ class IsogenyClass_EC(SageObject):
def __getitem__(self, i):
"""
- Return the `i` th curve in the class.
+ Return the `i`-th curve in the class.
EXAMPLES:: Other changes just remove white spaces. |
comment:11
ok, I understand. Seems to be good to go. |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Changed dependencies from #30448 to none |
comment:13
Thank you! |
Changed branch from public/34160 to |
Part of #34157:
Component: documentation
Author: Frédéric Chapoton
Branch/Commit:
92d28b3
Reviewer: Kwankyu Lee, Matthias Koeppe
Issue created by migration from https://trac.sagemath.org/ticket/34160
The text was updated successfully, but these errors were encountered: