Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docstring markup in sage/interacts and sage/rings #34169

Closed
kwankyu opened this issue Jul 12, 2022 · 12 comments
Closed

Fix docstring markup in sage/interacts and sage/rings #34169

kwankyu opened this issue Jul 12, 2022 · 12 comments

Comments

@kwankyu
Copy link
Collaborator

kwankyu commented Jul 12, 2022

Part of #34157:

sage/interacts/library.py:94:1: RST301 Unexpected indentation.
sage/rings/quotient_ring.py:17:1: RST303 Unknown directive type "todo".
sage/rings/localization.py:5:1: RST201 Block quote ends without a blank line; unexpected unindent.
sage/rings/padics/padic_lattice_element.py:621:1: RST218 Literal block expected; none found.
sage/rings/padics/padic_lattice_element.py:664:1: RST218 Literal block expected; none found.
sage/rings/padics/padic_lattice_element.py:1282:1: RST218 Literal block expected; none found.
sage/rings/number_field/number_field_ideal.py:3016:1: RST301 Unexpected indentation.
sage/rings/number_field/number_field_ideal.py:3017:1: RST201 Block quote ends without a blank line; unexpected unindent.
sage/rings/number_field/number_field_ideal.py:3261:1: RST201 Block quote ends without a blank line; unexpected unindent.
sage/rings/number_field/number_field_ideal.py:3326:1: RST201 Block quote ends without a blank line; unexpected unindent.

Component: documentation

Author: Frédéric Chapoton

Branch/Commit: 4950d2b

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/34169

@kwankyu kwankyu added this to the sage-9.7 milestone Jul 12, 2022
@kwankyu

This comment has been minimized.

@fchapoton
Copy link
Contributor

Author: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:2

there remains one failure in localization that I do not understand


New commits:

f2b44c5rst fixes in rings and interacts

@fchapoton
Copy link
Contributor

Branch: u/chapoton/34169

@fchapoton
Copy link
Contributor

Commit: f2b44c5

@jhpalmieri
Copy link
Member

comment:3

Same issue here as in #34167 and #34168, I think.

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 14, 2022

comment:4

This change is not correct:

@@ -32,8 +32,8 @@ three elements::
     sage: u = [u0, u1, u2]
     sage: S = Set(u)
     sage: I = S.cartesian_product(S)
-    sage: add_units = u + [q, q+1] + [ui -uj for ui, uj in I if ui != uj]\
-                        + [q*ui -uj for ui, uj in I if ui != uj]
+    sage: add_units = u + [q, q+1] + [ui -uj for ui, uj in I if ui != uj]
+    ....:                + [q*ui -uj for ui, uj in I if ui != uj]
     sage: L = R.localization(tuple(add_units)); L
     Multivariate Polynomial Ring in u0, u1, u2, q over Integer Ring localized at
     (q, q + 1, u2, u1, u1 - u2, u0, u0 - u2, u0 - u1, u2*q - u1, u2*q - u0,

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 14, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

4950d2bfix one detail

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 14, 2022

Changed commit from f2b44c5 to 4950d2b

@fchapoton
Copy link
Contributor

comment:6

ok, comment:4 is now fixed

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 14, 2022

Reviewer: Matthias Koeppe

@vbraun
Copy link
Member

vbraun commented Aug 1, 2022

Changed branch from u/chapoton/34169 to 4950d2b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants