Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove imports from sage.rings.all in sage.modular #34191

Closed
mkoeppe opened this issue Jul 16, 2022 · 10 comments
Closed

Remove imports from sage.rings.all in sage.modular #34191

mkoeppe opened this issue Jul 16, 2022 · 10 comments
Labels
p: minor / 4 t: enhancement t: refactoring
Milestone
sage-9.7

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 16, 2022

Part of Meta-ticket #34201: Replace imports from sage.*.all for namespace packages

Also clean up some other outdated importing practices.

CC: @DavidAyotte

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: f76fe41

Reviewer: David Ayotte

Issue created by migration from https://trac.sagemath.org/ticket/34191
@mkoeppe mkoeppe added this to the sage-9.7 milestone Jul 16, 2022
@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 25, 2022

Branch: u/mkoeppe/remove_imports_from_sage_rings_all_in_sage_modular

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 25, 2022

Commit: f76fe41

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 25, 2022

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 25, 2022

New commits:

f76fe41src/sage/modular: Remove imports from sage.rings.all and .all of other namespace packages

@DavidAyotte
Copy link
Member

Reviewer: David Ayotte

@DavidAyotte
Copy link
Member

comment:5

It all looks good to me, thanks! May I ask, is there a reason why this was done? Is it part of the modularization process?

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 25, 2022

comment:6

Thanks for the review!

Yes, sorry, I should have put it in the ticket description: It is for modularization - see ​https://doc.sagemath.org/html/en/developer/packaging_sage_library.html#module-level-runtime-dependencies

@vbraun
Copy link
Member

vbraun commented Aug 30, 2022

Changed branch from u/mkoeppe/remove_imports_from_sage_rings_all_in_sage_modular to f76fe41

@vbraun vbraun closed this as completed in 9cafd35 Aug 30, 2022
This was referenced Aug 29, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: minor / 4 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
3 participants
@vbraun @mkoeppe @DavidAyotte