Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ideals of non-maximal orders in number fields #34198

Closed
yyyyx4 opened this issue Jul 19, 2022 · 2 comments · Fixed by #35762
Closed

ideals of non-maximal orders in number fields #34198

yyyyx4 opened this issue Jul 19, 2022 · 2 comments · Fixed by #35762

Comments

@yyyyx4
Copy link
Member

yyyyx4 commented Jul 19, 2022

Currently (Sage 9.6), trying to construct an ideal of a non-maximal order in a number field errors out.

We should at least have a basic implementation that supports the standard ideal operations. This can serve as a foundation to which specialized code (such as for class-group computations, cf. #27413) can later be added as needed.

Component: number fields

Issue created by migration from https://trac.sagemath.org/ticket/34198

@grhkm21
Copy link
Contributor

grhkm21 commented May 19, 2023

Hi, this is my first time contributing to Sage (iirc). I would like to help on this, since it seems critical to get things related to endomorphism rings of elliptic curves into Sage.

I saw that #27413 essentially already has a working implementation (commit sagemath/sagetrac-mirror@3df71d5, I haven't checked whether all methods are implemented, but it seems that the core functionalities of constructing an ideal in a non-maximal order are there). Will that be a good place to start on, or are there any reasons it doesn't work here?

@yyyyx4
Copy link
Member Author

yyyyx4 commented Jun 13, 2023

I've pushed the somewhat unfinished branch I had lying around for this. It probably needs a little bit more work, such as implementing an ideal .factor() method: The other branch you mentioned seems to have .prime_factors(), so maybe we can copy that over and then implement .factor() on top of it?

(I would leave class-group-related functionality for a future issue.)

@vbraun vbraun closed this as completed in a9558bb Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants