Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.gitpod.yml: Do not hardcode the workspace name as sagetrac-mirror #34270

Closed
mkoeppe opened this issue Aug 3, 2022 · 9 comments
Closed

.gitpod.yml: Do not hardcode the workspace name as sagetrac-mirror #34270

mkoeppe opened this issue Aug 3, 2022 · 9 comments
Labels
c: user interface p: blocker / 1 t: bug
Milestone
sage-9.7

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 3, 2022

For example https://gitpod.io/#https://github.com/sagemath/sage, which appears as a link in our manuals, for instance,

does not work because the workspace directory is /workspace/sage, not /workspace/sagetrac-mirror

CC: @tobiasdiez @dimpase

Component: user interface

Author: Matthias Koeppe

Branch/Commit: eb839d4

Reviewer: Kwankyu Lee

Issue created by migration from https://trac.sagemath.org/ticket/34270
@mkoeppe mkoeppe added this to the sage-9.7 milestone Aug 3, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 3, 2022

Branch: u/mkoeppe/_gitpod_yml__do_not_hardcode_the_workspace_name_as_sagetrac_mirror

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 3, 2022

New commits:

eb839d4.gitpod.yml: Use $(pwd) to refer to the workspace dir

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 3, 2022

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 3, 2022

Commit: eb839d4

@kwankyu
Copy link
Collaborator

kwankyu commented Aug 9, 2022

Reviewer: Kwankyu Lee

@kwankyu
Copy link
Collaborator

kwankyu commented Aug 9, 2022

comment:4

Yes, it works.

@kwankyu

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 9, 2022

comment:6

Thanks!

@vbraun
Copy link
Member

vbraun commented Aug 29, 2022

Changed branch from u/mkoeppe/_gitpod_yml__do_not_hardcode_the_workspace_name_as_sagetrac_mirror to eb839d4

@vbraun vbraun closed this as completed in 696bf78 Aug 29, 2022
This was referenced Aug 29, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: user interface p: blocker / 1 t: bug
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
3 participants
@vbraun @kwankyu @mkoeppe