Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix E251 in interacts and interfaces #34329

Closed
fchapoton opened this issue Aug 10, 2022 · 12 comments
Closed

fix E251 in interacts and interfaces #34329

fchapoton opened this issue Aug 10, 2022 · 12 comments

Comments

@fchapoton
Copy link
Contributor

about

E251 unexpected spaces around keyword / parameter equals

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: acde465

Reviewer: David Coudert

Issue created by migration from https://trac.sagemath.org/ticket/34329

@fchapoton fchapoton added this to the sage-9.7 milestone Aug 10, 2022
@fchapoton
Copy link
Contributor Author

Commit: 4ada570

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/34329

@fchapoton
Copy link
Contributor Author

New commits:

4ada570E251 in interfaces and interacts

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 10, 2022

Changed commit from 4ada570 to 5662573

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 10, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

5662573a few more E251 fixes

@dcoudert
Copy link
Contributor

Reviewer: David Coudert

@dcoudert
Copy link
Contributor

comment:3

In src/sage/functions/bessel.py and src/sage/functions/jacobi.py, why not creating the dictionary before the call to BuiltinFunction.__init__ like that ?

+.       conversions = {'mathematica': 'SphericalBesselJ',
+                       'maxima': 'spherical_bessel_j',
+                       'sympy': 'jn'}
         BuiltinFunction.__init__(self, 'spherical_bessel_J', nargs=2,
-                                 conversions=dict(mathematica=
-                                                  'SphericalBesselJ',
-                                                  maxima='spherical_bessel_j',
-                                                  sympy='jn'))
+                                 conversions=conversions)

You should not touch src/sage/parallel/ncpus.py due to #34328.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 10, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

acde465E251 in interfaces and interacts

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 10, 2022

Changed commit from 5662573 to acde465

@fchapoton
Copy link
Contributor Author

comment:5

en effet, merci

voici une nouvelle branche qui evite de toucher le fichier modifié par #34328

j'ai aussi defini le dictionnaire "conversions" à deux ou trois endroits

@dcoudert
Copy link
Contributor

comment:6

LGTM.

@vbraun
Copy link
Member

vbraun commented Aug 30, 2022

Changed branch from u/chapoton/34329 to acde465

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants