Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pycodestyle cleanup in src/sage/graphs/generic_graph.py (part 4) #34358

Closed
dcoudert opened this issue Aug 13, 2022 · 15 comments
Closed

pycodestyle cleanup in src/sage/graphs/generic_graph.py (part 4) #34358

dcoudert opened this issue Aug 13, 2022 · 15 comments
Labels
c: graph theory p: minor / 4 t: enhancement
Milestone
sage-9.8

Comments

@dcoudert
Copy link
Contributor

Depends on #34357

Component: graph theory

Author: David Coudert

Branch/Commit: b1db4f1

Reviewer: Kwankyu Lee

Issue created by migration from https://trac.sagemath.org/ticket/34358
@dcoudert dcoudert added this to the sage-9.7 milestone Aug 13, 2022
@dcoudert
Copy link
Contributor Author

Branch: public/graphs/34358_gen4

@dcoudert
Copy link
Contributor Author

Commit: dcbbba2

@dcoudert
Copy link
Contributor Author

New commits:

dcbbba2trac #34358: clean src/sage/graphs/generic_graph.py - part 4

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 13, 2022

Changed commit from dcbbba2 to c69daa7

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 13, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

c69daa7trac #34358: a few more

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 20, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

444a55atrac #34318: clean src/sage/graphs/generic_graph.py - part 1
328cc6atrac #34318: fix pyflakes issue
b62e29etrac #34319: clean src/sage/graphs/generic_graph.py - part 2
dc4bcbdtrac #34319: merge with #34318
598744etrac #34357: clean src/sage/graphs/generic_graph.py - part 3
8704f2btrac #34357: merge with #34319
6b3dc99trac #34358: merge with #34357

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 20, 2022

Changed commit from c69daa7 to 6b3dc99

@dcoudert
Copy link
Contributor Author

Dependencies: #34357

@dcoudert
Copy link
Contributor Author

comment:4

This ticket now depends on #34357, which itself depends on #34319, etc.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 20, 2022

Changed commit from 6b3dc99 to b1db4f1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 20, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

b1db4f1trac #34358: extra care

@dcoudert
Copy link
Contributor Author

comment:6

I fixed an extra indentation.

@kwankyu
Copy link
Collaborator

kwankyu commented Sep 16, 2022

comment:7

LGTM.

@kwankyu
Copy link
Collaborator

kwankyu commented Sep 16, 2022

Reviewer: Kwankyu Lee

@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Sep 19, 2022
@vbraun
Copy link
Member

vbraun commented Sep 27, 2022

Changed branch from public/graphs/34358_gen4 to b1db4f1

@vbraun vbraun closed this as completed in ce82f81 Sep 27, 2022
@dcoudert dcoudert mentioned this issue Sep 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: graph theory p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
4 participants
@vbraun @kwankyu @mkoeppe @dcoudert