Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new bunch of fixed typos #34382

Closed
fchapoton opened this issue Aug 17, 2022 · 10 comments
Closed

new bunch of fixed typos #34382

fchapoton opened this issue Aug 17, 2022 · 10 comments

Comments

@fchapoton
Copy link
Contributor

found using egrep

Component: documentation

Author: Frédéric Chapoton

Branch/Commit: 4bf4dcc

Reviewer: Dave Morris

Issue created by migration from https://trac.sagemath.org/ticket/34382

@fchapoton fchapoton added this to the sage-9.7 milestone Aug 17, 2022
@fchapoton
Copy link
Contributor Author

New commits:

352fed2new wavelet of fixed typos

@fchapoton
Copy link
Contributor Author

Commit: 352fed2

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/34382

@DaveWitteMorris
Copy link
Member

comment:2

Here are minor amendments to a few of your corrections.

Change "Theoerem" to "Theorem" in

/src/sage/combinat/designs/bibd.py
# Non-existence by BRC Theoerem

Change "occurence" to "occurrence" in

/src/sage/misc/misc.py
once: keep only the first occurence of any item.

Change "improve" to "improved" and change "how about it already" to "go about that yet" in

/src/sage/rings/number_field/number_field.py
# d could be improve to be the exponent of the Galois group rather than the degree, but I do not see how to how about it already.

Change "safe" to "save" in

/src/sage/symbolic/ginac/mul.cpp
 *  to allow for early cancellations and thus safe memory.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 17, 2022

Changed commit from 352fed2 to 4bf4dcc

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 17, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

4bf4dccfix details

@fchapoton
Copy link
Contributor Author

comment:4

voilà

@DaveWitteMorris
Copy link
Member

comment:5

Thanks for fixing these typos. The patchbot failures have nothing to do with this ticket (and I ran make testlong with no errors).

@DaveWitteMorris
Copy link
Member

Reviewer: Dave Morris

@vbraun
Copy link
Member

vbraun commented Aug 30, 2022

Changed branch from u/chapoton/34382 to 4bf4dcc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants