Put tensor modules of FiniteRankFreeModule in Modules().TensorProducts() #34448

`e31bdac`	`TensorFreeModule._an_element_: Pass parent to element class`
`e7d5e77`	`TensorFreeModule._an_element_: Use element constructor`
`18d3dbe`	`TensorFreeSubmodule_comp._is_symmetry_coarsening_of: Update example`
`3f1c33d`	`TensorFreeSubmoduleBasis_comp.__init__: Add doctest`
`9378a78`	`src/sage/tensor/modules/finite_rank_free_module.py: Update doctest output`
`66874a9`	`src/sage/sets/family.py: Add doctest`
`877d17e`	`Merge #30300`
`cb43784`	`Merge #30229`
`9ce4fed`	`FiniteRankFreeModule, VectorFieldModule, VectorFieldFreeModule: Method tensor has to double as the functorial construction`
`87c9392`	`TensorFreeModule: Use Modules().TensorProducts() except for type (0,1)`

mkoeppe · 2022-08-29T02:39:01Z

Commit: 87c9392

mkoeppe · 2022-08-29T02:39:01Z

Author: Matthias Koeppe

sagetrac-git · 2022-08-29T02:44:09Z

Changed commit from 87c9392 to d92122d

sagetrac-git · 2022-08-29T02:44:09Z

Branch pushed to git repo; I updated commit sha1. New commits:

`d92122d`	`src/sage/tensor/modules/tensor_free_submodule.py: Add comment`

sagetrac-git · 2022-09-02T18:26:09Z

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

`39bfe8d`	`Merge #34451`
`bec2f65`	`CompWithSym._canonicalize_sym_antisym: Refactor, fix index validation, add tests`
`66009e7`	`src/sage/tensor/modules/comp.py: Fix docstring`
`64e3c1d`	`Merge #34451`
`7474abb`	`FiniteRankFreeModule_abstract.tensor_product: Handle submodules with symmetries`
`ed3c8d9`	`src/sage/tensor/modules/finite_rank_free_module.py (FiniteRankFreeModule_abstract.is_submodule): Fix typo in doctest`
`fd89892`	`src/sage/tensor/modules/tensor_free_submodule[_basis].py, finite_rank_free_module.py: Update AUTHORS`
`644933a`	`src/sage/tensor/modules/finite_rank_free_module.py: Update copyright according to git blame -w --date=format:%Y FILE \| sort -k2`
`45bf6f3`	`FiniteRankFreeModule_abstract.tensor_product: Add comment`
`64a6ca3`	`Merge #30229`

sagetrac-git · 2022-09-02T18:26:09Z

Changed commit from d92122d to 64a6ca3

sagetrac-git · 2022-09-02T18:37:14Z

Changed commit from 64a6ca3 to 76476a0

sagetrac-git · 2022-09-02T18:37:14Z

Branch pushed to git repo; I updated commit sha1. New commits:

`76476a0`	`VectorField[Free]Module.tensor_module: Accept trivial sym, antisym parameters`

sagetrac-git · 2022-09-04T19:36:26Z

Branch pushed to git repo; I updated commit sha1. New commits:

`dd6cc0e`	`Merge branch 'u/chapoton/tensor_components' in 9.7.rc0`
`b81dbf0`	`fix doctest`
`f1c7aab`	`Merge #34393`
`803f7e4`	`Make FiniteRankFreeModule.tensor_module(0, 1) return the dual (#34474)`
`0648daa`	`Merge #34474`
`fc66ad1`	`FiniteRankFreeModule.dual_symmetric_power: Update for changes in #34474`
`457572b`	`Merge #30229`
`8db6cc5`	`TensorFreeModule.tensor_factors: Use dual`

sagetrac-git · 2022-09-04T19:36:26Z

Changed commit from 76476a0 to 8db6cc5

mkoeppe · 2022-09-06T18:51:56Z

Changed dependencies from #34424, #34393, #31276, #30235, #30229 to #34424, #34393, #31276, #30235, #30229, #30241

mkoeppe · 2022-09-06T19:20:59Z

Changed dependencies from #34424, #34393, #31276, #30235, #30229, #30241 to #34424, #34393, #31276, #30235, #30229, #30241, #34501

sagetrac-git · 2022-09-06T21:37:08Z

Branch pushed to git repo; I updated commit sha1. New commits:

`a1b32c0`	`Merge #34474`
`94f59b8`	`FiniteRankDualFreeModule: New, remove special case from ExtPowerDualFreeModule`
`37e41b9`	`FiniteRankDualFreeModule.tensor_type: New; add tensor_product doctests`
`5044024`	`FiniteRankDualFreeModule: Doc fixes`
`84d7b5e`	`ExtPower[Dual]FreeModule, FiniteRankDualFreeModule: Add docstring to construction method`
`050fbc6`	`Merge #30241`
`b9b9deb`	`src/sage/tensor/modules/tensor_free_module.py: Update doctest output`
`b392efa`	`FiniteRankFreeModule_abstract.tensor: New`

sagetrac-git · 2022-09-06T21:37:08Z

Changed commit from 8db6cc5 to b392efa

sagetrac-git · 2022-09-07T00:57:44Z

Branch pushed to git repo; I updated commit sha1. New commits:

`b5c666c`	`Merge #30241`
`0d2539a`	`VectorFieldModule: Faster fast path for tensor_module, exterior_power, dual_exterior_power`
`f06fc5e`	`Merge #34486`
`c7428e2`	`src/sage/manifolds/differentiable/diff_form_module.py (VectorFieldDualFreeModule): New`
`8bfb9ff`	`VectorFieldFreeModule.tensor_module: For (0,1), use the dual`
`af96b06`	`src/sage/manifolds/differentiable/diff_form_module.py: Update doctest output`
`bc99257`	`src/sage/manifolds/differentiable/diff_form_module.py: Fix doctests`
`0155026`	`src/sage/manifolds/differentiable/diff_form_module.py: Remove some doctests on coercions`
`7f66f96`	`Merge #34501`

sagetrac-git · 2022-09-07T00:57:44Z

Changed commit from b392efa to 7f66f96

sagetrac-git · 2022-09-07T01:04:38Z

Branch pushed to git repo; I updated commit sha1. New commits:

`620df16`	`src/sage/tensor/modules/tensor_free_submodule.py: Remove tensor_factors, add doctest for construction`

sagetrac-git · 2022-09-07T01:04:38Z

Changed commit from 7f66f96 to 620df16

sagetrac-git · 2022-09-07T18:14:09Z

Branch pushed to git repo; I updated commit sha1. New commits:

`4c9be6b`	`src/sage/manifolds/differentiable/diff_form_module.py: doc: add that the case p=1 of M parallelizable is implemented via VectorFieldDualFreeModule`
`06710c1`	`src/sage/manifolds/differentiable/diff_form_module.py, vectorfield_module.py: Update copyright using 'git blame -w --date=format:%Y FILE.py \| sort -k2', add to AUTHORS`
`bb614c1`	`Merge #34501`

sagetrac-git · 2022-09-07T18:14:09Z

Changed commit from 620df16 to bb614c1

sagetrac-git · 2022-09-24T21:54:51Z

Changed commit from bb614c1 to 4a4a29d

sagetrac-git · 2022-09-24T21:54:51Z

Branch pushed to git repo; I updated commit sha1. New commits:

`4a4a29d`	`Merge tag '9.7' into t/34448/put_tensor_modules_of_finiterankfreemodule_in_modules___tensorproducts__`

sagetrac-git · 2022-09-25T23:37:53Z

Changed commit from 4a4a29d to 1f4fb90

sagetrac-git · 2022-09-25T23:37:53Z

Branch pushed to git repo; I updated commit sha1. New commits:

`1f4fb90`	`Merge tag '9.8.beta0' into t/34448/put_tensor_modules_of_finiterankfreemodule_in_modules___tensorproducts__`

sagetrac-git · 2022-09-25T23:43:08Z

Branch pushed to git repo; I updated commit sha1. New commits:

`7c04959`	`src/sage/manifolds/differentiable/diff_form_module.py: Fix typo in docstring`
`fc31cbf`	`Merge #34501`
`f0def92`	`src/sage/tensor/modules/tensor_free_module.py: Remove redundant method`

sagetrac-git · 2022-09-25T23:43:08Z

Changed commit from 1f4fb90 to f0def92

egourgoulhon · 2022-09-26T13:55:25Z

comment:22

LGTM for the part in sage.tensor.modules. Regarding the part in sage.manifolds.differentiable, there are the following changes in the class VectorFieldModule:

-    def tensor(self, tensor_type, name=None, latex_name=None, sym=None,
+    def _tensor(self, tensor_type, name=None, latex_name=None, sym=None,

and

+    tensor = FiniteRankFreeModule.tensor

Now, instances of VectorFieldModule are not free modules (those are implemented via VectorFieldFreeModule instead), so having VectorFieldModule.tensor being FiniteRankFreeModule.tensor looks problematic. For instance:

sage: M = manifolds.Sphere(2)
sage: XM = M.vector_field_module()
sage: XM.tensor?
   Construct a tensor on the free module "self" or a tensor product
   with other modules.
   ...

but self is not a free module. Maybe declaring tensor = _tensor would be preferable here.

I understand that bringing tensor modules on VectorFieldModule in Modules().TensorProducts() is beyond the scope of this ticket. In particular we have still category=Modules(self._ring) in TensorFieldModule.__init__.

mkoeppe · 2022-09-26T17:19:57Z

comment:23

Replying to Eric Gourgoulhon:

I understand that bringing tensor modules on VectorFieldModule in Modules().TensorProducts() is beyond the scope of this ticket.

The next step in this direction is #34589

sagetrac-git · 2022-09-26T17:21:56Z

Branch pushed to git repo; I updated commit sha1. New commits:

`e10f9cf`	`src/sage/manifolds/differentiable/vectorfield_module.py: Revert change to VectorFieldModule.tensor (not needed yet)`

sagetrac-git · 2022-09-26T17:21:56Z

Changed commit from f0def92 to e10f9cf

mkoeppe · 2022-09-26T17:22:30Z

comment:25

Replying to Eric Gourgoulhon:

LGTM for the part in sage.tensor.modules. Regarding the part in sage.manifolds.differentiable, there are the following changes in the class VectorFieldModule:
-    def tensor(self, tensor_type, name=None, latex_name=None, sym=None,
+    def _tensor(self, tensor_type, name=None, latex_name=None, sym=None,
and
+    tensor = FiniteRankFreeModule.tensor

Thanks for catching this. I've reverted this change.

egourgoulhon · 2022-09-27T09:23:44Z

comment:26

Thanks!

egourgoulhon · 2022-09-27T09:23:44Z

Reviewer: Eric Gourgoulhon

mkoeppe · 2022-09-27T17:52:33Z

comment:27

Thank you!

vbraun · 2022-09-29T21:02:29Z

Changed branch from u/mkoeppe/put_tensor_modules_of_finiterankfreemodule_in_modules___tensorproducts__ to e10f9cf

mkoeppe added this to the sage-9.7 milestone Aug 28, 2022

mkoeppe added c: categories labels Aug 28, 2022

This comment has been minimized.

Sign in to view

mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 31, 2022

This comment has been minimized.

Sign in to view

mkoeppe added the s: needs review label Sep 7, 2022

egourgoulhon added s: positive review and removed s: needs review labels Sep 27, 2022

vbraun removed the s: positive review label Sep 29, 2022

vbraun closed this as completed in 3bf2df7 Sep 29, 2022

egourgoulhon mentioned this issue Sep 4, 2022

New implementation class FiniteRankDualFreeModule #30241

Closed

tscrim mentioned this issue Sep 5, 2022

Parent methods tensor vs. tensor_product #30373

Open

egourgoulhon mentioned this issue Jan 30, 2023

SageManifolds metaticket 2 #30525

Open

Put tensor modules of FiniteRankFreeModule in Modules().TensorProducts() #34448

Put tensor modules of FiniteRankFreeModule in Modules().TensorProducts() #34448

Comments

mkoeppe commented Aug 28, 2022

mkoeppe commented Aug 28, 2022

This comment has been minimized.

mkoeppe commented Aug 29, 2022

mkoeppe commented Aug 29, 2022

mkoeppe commented Aug 29, 2022

mkoeppe commented Aug 29, 2022

mkoeppe commented Aug 29, 2022

sagetrac-git mannequin commented Aug 29, 2022

sagetrac-git mannequin commented Aug 29, 2022

sagetrac-git mannequin commented Sep 2, 2022

sagetrac-git mannequin commented Sep 2, 2022

sagetrac-git mannequin commented Sep 2, 2022

sagetrac-git mannequin commented Sep 2, 2022

This comment has been minimized.

sagetrac-git mannequin commented Sep 4, 2022

sagetrac-git mannequin commented Sep 4, 2022

mkoeppe commented Sep 6, 2022

mkoeppe commented Sep 6, 2022

sagetrac-git mannequin commented Sep 6, 2022

sagetrac-git mannequin commented Sep 6, 2022

sagetrac-git mannequin commented Sep 7, 2022

sagetrac-git mannequin commented Sep 7, 2022

sagetrac-git mannequin commented Sep 7, 2022

sagetrac-git mannequin commented Sep 7, 2022

sagetrac-git mannequin commented Sep 7, 2022

sagetrac-git mannequin commented Sep 7, 2022

sagetrac-git mannequin commented Sep 24, 2022

sagetrac-git mannequin commented Sep 24, 2022

sagetrac-git mannequin commented Sep 25, 2022

sagetrac-git mannequin commented Sep 25, 2022

sagetrac-git mannequin commented Sep 25, 2022

sagetrac-git mannequin commented Sep 25, 2022

egourgoulhon commented Sep 26, 2022

mkoeppe commented Sep 26, 2022

sagetrac-git mannequin commented Sep 26, 2022

sagetrac-git mannequin commented Sep 26, 2022

mkoeppe commented Sep 26, 2022

egourgoulhon commented Sep 27, 2022

egourgoulhon commented Sep 27, 2022

mkoeppe commented Sep 27, 2022

vbraun commented Sep 29, 2022