Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make FiniteRankFreeModule.tensor_module(0, 1) return the dual #34474

Closed
egourgoulhon opened this issue Sep 1, 2022 · 7 comments
Closed

Make FiniteRankFreeModule.tensor_module(0, 1) return the dual #34474

egourgoulhon opened this issue Sep 1, 2022 · 7 comments
Labels
c: linear algebra p: major / 3 t: bug
Milestone
sage-9.8

Comments

@egourgoulhon
Copy link
Member

In Sage 9.7.rc0, we have

sage: M = FiniteRankFreeModule(ZZ, 2, name='M')
sage: M.tensor_module(0, 1) is M.dual()
False

The identity of the two objects, which is mathematically exact, is implemented here. This also simplifies some coercion maps.

CC: @mkoeppe @tscrim @mjungmath

Component: linear algebra

Keywords: tensor_module

Author: Eric Gourgoulhon

Branch/Commit: 803f7e4

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/34474
@egourgoulhon egourgoulhon added this to the sage-9.7 milestone Sep 1, 2022
@egourgoulhon
Copy link
Member Author

Branch: public/manifolds/tensor_module_dual-34474

@egourgoulhon
Copy link
Member Author

Commit: 803f7e4

@egourgoulhon
Copy link
Member Author

New commits:

803f7e4Make FiniteRankFreeModule.tensor_module(0, 1) return the dual (#34474)

@mkoeppe
Copy link
Contributor

mkoeppe commented Sep 1, 2022

Reviewer: Matthias Koeppe

@mkoeppe
Copy link
Contributor

mkoeppe commented Sep 1, 2022

comment:2

LGTM and passes all tests.

Possible follow-up - #30241

@egourgoulhon
Copy link
Member Author

comment:3

Thanks for the review!

@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Sep 19, 2022
@vbraun
Copy link
Member

vbraun commented Sep 22, 2022

Changed branch from public/manifolds/tensor_module_dual-34474 to 803f7e4

@vbraun vbraun closed this as completed in 857f16c Sep 22, 2022
This was referenced Sep 4, 2022
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: linear algebra p: major / 3 t: bug
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
3 participants
@vbraun @egourgoulhon @mkoeppe