Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect decomposition type for relative number fields #34514

Closed
roed314 opened this issue Sep 9, 2022 · 7 comments
Closed

Incorrect decomposition type for relative number fields #34514

roed314 opened this issue Sep 9, 2022 · 7 comments
Labels
c: number fields p: major / 3 t: bug
Milestone
sage-9.8

Comments

@roed314
Copy link
Contributor

roed314 commented Sep 9, 2022 

sage: K.<a> = NumberField(x^4 + 18*x^2 - 1)
sage: R.<y> = K[]
sage: L.<b> = K.extension(y^2 + 9*a^3 - 2*a^2 + 162*a - 38)
sage: [L.decomposition_type(i) for i in K.primes_above(3)]
[[(1, 1, 2)], [(1, 1, 2)], [(1, 1, 1)]]

The last triple should be (1, 2, 1).

Component: number fields

Author: David Roe

Branch/Commit: e538c5d

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/34514
@roed314 roed314 added this to the sage-9.8 milestone Sep 9, 2022
@roed314
Copy link
Contributor Author

roed314 commented Sep 9, 2022

Branch: u/roed/decomposition_type

@roed314
Copy link
Contributor Author

roed314 commented Sep 9, 2022

New commits:

e538c5dFix bug in decomposition_type

@roed314
Copy link
Contributor Author

roed314 commented Sep 9, 2022

Author: David Roe

@roed314
Copy link
Contributor Author

roed314 commented Sep 9, 2022

Commit: e538c5d

@tscrim
Copy link
Collaborator

tscrim commented Sep 10, 2022

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Sep 10, 2022

comment:3

LGTM.

@vbraun
Copy link
Member

vbraun commented Sep 25, 2022

Changed branch from u/roed/decomposition_type to e538c5d

@vbraun vbraun closed this as completed in 46b5052 Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: number fields p: major / 3 t: bug
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
3 participants
@roed314 @vbraun @tscrim