Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dead hyperlinks in developer manual #34740

Closed
DavidAyotte opened this issue Nov 10, 2022 · 12 comments
Closed

dead hyperlinks in developer manual #34740

DavidAyotte opened this issue Nov 10, 2022 · 12 comments
Labels
c: documentation p: trivial / 5 t: bug
Milestone
sage-9.8

Comments

@DavidAyotte
Copy link
Member

The following section of the developer manual:

https://doc.sagemath.org/html/en/developer/sage_manuals.html

contains multiple reference to a dead link:

http://sphinx.pocoo.org

Component: documentation

Keywords: hyperlinks

Author: David Ayotte

Branch/Commit: bdc07ac

Reviewer: Kwankyu Lee

Issue created by migration from https://trac.sagemath.org/ticket/34740
@DavidAyotte DavidAyotte added this to the sage-9.8 milestone Nov 10, 2022
@DavidAyotte

This comment has been minimized.

Sign in to view
@DavidAyotte
Copy link
Member Author

Branch: u/gh-DavidAyotte/sphinx_doc_hyperlink

@DavidAyotte
Copy link
Member Author

Commit: dabdf89

@DavidAyotte
Copy link
Member Author

New commits:

dabdf89src/doc/en/developer/sage_manuals.rst: fix dead links

@DavidAyotte
Copy link
Member Author

Author: David Ayotte

@DavidAyotte DavidAyotte changed the title dead hyperlink in developer manual dead hyperlinks in developer manual Nov 11, 2022
@kwankyu
Copy link
Collaborator

kwankyu commented Nov 11, 2022

comment:4

It seems that http://www.sphinx-doc.org/markup/inline.html can be replaced with https://www.sphinx-doc.org/en/master/usage/restructuredtext/roles.html

@DavidAyotte
Copy link
Member Author

comment:5

Replying to Kwankyu Lee:

It seems that http://www.sphinx-doc.org/markup/inline.html can be replaced with https://www.sphinx-doc.org/en/master/usage/restructuredtext/roles.html

You're right, this is a better choice. Thanks!

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 11, 2022

Changed commit from dabdf89 to bdc07ac

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 11, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

bdc07acsrc/doc/en/developer/sage_manuals.rst: change hyperlink

@kwankyu
Copy link
Collaborator

kwankyu commented Nov 11, 2022

Reviewer: Kwankyu Lee

@kwankyu
Copy link
Collaborator

kwankyu commented Nov 11, 2022

comment:7

Thanks. LGTM.

@vbraun
Copy link
Member

vbraun commented Dec 3, 2022

Changed branch from u/gh-DavidAyotte/sphinx_doc_hyperlink to bdc07ac

@vbraun vbraun closed this as completed in 3670306 Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: documentation p: trivial / 5 t: bug
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
3 participants
@vbraun @kwankyu @DavidAyotte