Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS X 13: filter out dylib warning #34741

Closed
jhpalmieri opened this issue Nov 11, 2022 · 11 comments
Closed

OS X 13: filter out dylib warning #34741

jhpalmieri opened this issue Nov 11, 2022 · 11 comments
Labels
c: doctest framework p: minor / 4 t: bug
Milestone
sage-9.8

Comments

@jhpalmieri
Copy link
Member

With OS X 13 and/or Xcode 14, Sage can produce warnings

ld: warning: dylib (/path/to/SAGE_ROOT/local/lib/libec.dylib) was built for newer macOS version (13.0) than being linked (12.3)

Let's filter these out when doctesting.

Component: doctest framework

Author: John Palmieri

Branch/Commit: bcab6e5

Reviewer: Kwankyu Lee

Issue created by migration from https://trac.sagemath.org/ticket/34741
@jhpalmieri jhpalmieri added this to the sage-9.8 milestone Nov 11, 2022
@jhpalmieri
Copy link
Member Author

Branch: u/jhpalmieri/newer_osx_warning

@jhpalmieri
Copy link
Member Author

Commit: 0da93be

@jhpalmieri
Copy link
Member Author

New commits:

0da93betrac 34741: suppress warnings about "dylib ... was built for newer macOS ..."

@kwankyu
Copy link
Collaborator

kwankyu commented Nov 13, 2022

comment:3

Perhaps needs to add a comment mentioning this ticket (at least the ticket number) to explain why the filter was added.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 13, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

bcab6e5trac 34741: add comment with ticket reference

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 13, 2022

Changed commit from 0da93be to bcab6e5

@jhpalmieri
Copy link
Member Author

comment:5

Good idea. Done.

@kwankyu
Copy link
Collaborator

kwankyu commented Nov 14, 2022

comment:6

Thanks. LGTM.

@kwankyu
Copy link
Collaborator

kwankyu commented Nov 14, 2022

Reviewer: Kwankyu Lee

@jhpalmieri
Copy link
Member Author

comment:7

Thank you!

@vbraun
Copy link
Member

vbraun commented Dec 3, 2022

Changed branch from u/jhpalmieri/newer_osx_warning to bcab6e5

@vbraun vbraun closed this as completed in f2fa759 Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: doctest framework p: minor / 4 t: bug
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
3 participants
@vbraun @kwankyu @jhpalmieri