Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade cmake to 3.24.3, increase minimum system cmake version to 3.11 #34746

Closed
mkoeppe opened this issue Nov 14, 2022 · 12 comments
Closed

Upgrade cmake to 3.24.3, increase minimum system cmake version to 3.11 #34746

mkoeppe opened this issue Nov 14, 2022 · 12 comments
Labels
c: packages: standard p: major / 3 t: enhancement
Milestone
sage-9.8

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Nov 14, 2022

scip (#31329) fails to build with the older cmake provided by ubuntu-xenial (scipopt/scip#32)

papilo (#34726) needs at least cmake 3.11.

3.10.x is shipped on ubuntu-bionic, linuxmint-19.

CC: @dimpase

Component: packages: standard

Author: Matthias Koeppe

Branch/Commit: 96a9e22

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/34746
@mkoeppe mkoeppe added this to the sage-9.8 milestone Nov 14, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 14, 2022

Branch: u/mkoeppe/upgrade_cmake_to_3_24_3__increase_minimum_system_cmake_version_to_3_10

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 14, 2022

Commit: dce791c

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 14, 2022

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 14, 2022

New commits:

d18036bbuild/pkgs/cmake: Update to 3.24.3
dce791cbuild/pkgs/cmake/spkg-configure.m4: Increase minimum version from 3.4 to 3.10 (as found on ubuntu-bionic)

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe mkoeppe changed the title Upgrade cmake to 3.24.3, increase minimum system cmake version to 3.10 Upgrade cmake to 3.24.3, increase minimum system cmake version to 3.11 Nov 14, 2022
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 14, 2022

Changed commit from dce791c to 96a9e22

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 14, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

96a9e22build/pkgs/cmake/spkg-configure.m4: Increase minimum version to 3.11

@dimpase
Copy link
Member

dimpase commented Nov 14, 2022

comment:6

lgtm

@dimpase
Copy link
Member

dimpase commented Nov 14, 2022

Reviewer: Dima Pasechnik

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 14, 2022

comment:7

Thanks!

@vbraun
Copy link
Member

vbraun commented Nov 20, 2022

Changed branch from u/mkoeppe/upgrade_cmake_to_3_24_3__increase_minimum_system_cmake_version_to_3_10 to 96a9e22

@vbraun vbraun closed this as completed in 576ea23 Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: standard p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
3 participants
@vbraun @dimpase @mkoeppe