Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage.schemes: Replace imports from sage.*.all for namespace packages #34951

Closed
mkoeppe opened this issue Jan 29, 2023 · 11 comments · Fixed by #35033
Closed

sage.schemes: Replace imports from sage.*.all for namespace packages #34951

mkoeppe opened this issue Jan 29, 2023 · 11 comments · Fixed by #35033

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 29, 2023

Using ./sage -fiximports from #34945.

Also remove trailing whitespace in the affected files.

Part of Meta-ticket #34201

CC: @alexchandler100 @bhutz @yyyyx4

Component: refactoring

Author: Alex Chandler, Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/34951

@mkoeppe mkoeppe added this to the sage-9.8 milestone Jan 29, 2023
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 29, 2023

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 29, 2023

Commit: dca994a

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 29, 2023

New commits:

dca994asrc/sage/schemes: Manual fixes to imports

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 29, 2023

Changed commit from dca994a to aefcd52

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 29, 2023

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

aefcd52sage -fiximports src/sage/schemes

@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Jan 29, 2023
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 30, 2023

Branch pushed to git repo; I updated commit sha1. New commits:

e545deagit grep -l -E ' (Q as QQ|Z as ZZ)' | xargs sed -i.bak 's/ Q as QQ/ QQ/;s/ Z as ZZ/ ZZ/;'
44af9b9sage.schemes: Consolidate imports from the same module

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 30, 2023

Changed commit from aefcd52 to 44af9b9

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 30, 2023

Changed commit from 44af9b9 to acf17b6

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 30, 2023

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

d52ad2csage -fiximports src/sage/schemes
4a7bfc1git grep -l -E ' (Q as QQ|Z as ZZ)' | xargs sed -i.bak 's/ Q as QQ/ QQ/;s/ Z as ZZ/ ZZ/;'
acf17b6sage.schemes: Consolidate imports from the same module

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 30, 2023

Changed author from Alex Chandler to Alex Chandler, Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 9, 2023

The attached branch is replaced by PR #35033.

mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
@vbraun vbraun closed this as completed in 0847642 Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant