Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show() regression: Picture cropped too much #7299

Closed
haaninjo opened this issue Oct 25, 2009 · 9 comments
Closed

show() regression: Picture cropped too much #7299

haaninjo opened this issue Oct 25, 2009 · 9 comments
Assignees
@williamstein
Labels
c: graphics p: major / 3 t: bug
Milestone
sage-4.3.2

Comments

@haaninjo
Copy link

In sage 4.1.2 and later, the show() function shows graphs so cropped that their vertices are partially missing.

This is a regression in 4.1.2 and later, Sage 4.1.1 is fine.

Attaching the figures from

G=graphs.CycleGraph(3);G.show()

to show the issue.

CC: @rlmill @rbeezer

Component: graphics

Author: Jason Grout

Reviewer: Robert Bradshaw

Merged: sage-4.3.2.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/7299
@haaninjo haaninjo added this to the sage-4.3.2 milestone Oct 25, 2009
@haaninjo
Copy link
Author

Attachment: Triangle-sage_4.1.1.png

Triangle graph in 4.1.1

@haaninjo
Copy link
Author

Attachment: Triangle-Sage_4.1.2.png

Triangle graph in 4.1.2

@jasongrout
Copy link
Member

comment:1

Attachment: trac-7299-graph-pad.patch.gz

@jasongrout
Copy link
Member

Author: Jason Grout

@jasongrout
Copy link
Member

comment:3

The attached patch is a one-line fix that makes graph vertices not be cut off now.

@robertwb
Copy link
Contributor

comment:4

LGTM. Such a small change for a big impact.

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jan 23, 2010

Reviewer: Robert Bradshaw

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jan 23, 2010

Merged: sage-4.3.2.alpha0

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jan 23, 2010

comment:5

Merged trac-7299-graph-pad.patch.

@sagetrac-mvngu sagetrac-mvngu mannequin closed this as completed Jan 23, 2010
@jasongrout jasongrout mentioned this issue Nov 7, 2011
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@williamstein williamstein

Labels
c: graphics p: major / 3 t: bug
Projects
None yet
Milestone
sage-4.3.2
Development

No branches or pull requests
4 participants
@jasongrout @robertwb @williamstein @haaninjo