-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tutorial on Python object and classes #8886
Comments
comment:1
I'm preparing a patch on sage-combinat queue... I took ownership of the ticket (to have it in the my ticket report). Florent |
Attachment: trac_8886-config.patch.gz |
This comment has been minimized.
This comment has been minimized.
Author: Minh Van Nguyen |
comment:2
The patch trac_8886-config.patch contains the Sphinx configuration and build files. Such files are required to get Sphinx to build documents in the category "Thematic Tutorials". When #8468 was merged, the prerequisites listed on that ticket were not merged at all. This meant that the relevant build and configuration files did not go into Sage 4.4.1. The patch trac_8886-config.patch is an attempt to fix this. You should apply this patch prior to adding any new documents to "Thematic Tutorials". |
comment:3
I have sage 4.3.5 and have been manually applying the doc patches. This one does not apply even though I have the prereqs. I have applied 8464, 8465, 8469, and 8442. Is that the wrong order? |
comment:4
Replying to @sagetrac-mjordan7:
I didn't mention that you need to apply patches on top of Sage 4.4.1. The patches on this ticket and the prequisite ticket were produced on top of Sage 4.4.1. Sorry for the inconvenience. |
This comment has been minimized.
This comment has been minimized.
comment:6
If #8465 is merged, then trac_8886-config.patch is no longer needed. |
This comment has been minimized.
This comment has been minimized.
Dependencies: 11251 |
Changed author from Minh Van Nguyen to Florent Hivert, Minh Van Nguyen |
Attachment: trac_8886-objects-classes_tutorial-fh.patch.gz |
This comment has been minimized.
This comment has been minimized.
comment:9
There is a mistake in thematic_tutorials/conf.py which prevents math like I've fixed some typos and grammatical errors. See the "delta" patch for the differences between my patch and the previous one. I'm happy with what you've done, so if you're happy with my changes, give the ticket a positive review. |
This comment has been minimized.
This comment has been minimized.
Reviewer: John Palmieri |
Attachment: trac_8886-delta.patch.gz |
comment:10
Attachment: trac_8886-objects-classes_tutorial-jhp.patch.gz Replying to @jhpalmieri:
I'll do it.
Thanks for correcting my bad English. I'm mostly happy with your change. The Thanks for your careful review. Florent |
comment:13
Nicolas pointed out the following typo: line 14:
"now" should be "no". I'm updating a corrected patch. |
comment:14
New new patch is updated it should be reviewed. The diff from the preceding patch is:
|
This comment has been minimized.
This comment has been minimized.
comment:15
Replying to @hivert:
I suggested that tiny change, so positive review on it :-) |
This comment has been minimized.
This comment has been minimized.
comment:16
Attachment: trac_8886-objects-classes_tutorial-fh-jhp-rebased.patch.gz |
Merged: sage-4.7.2.alpha4 |
As the subject says. See this sage-devel thread for some background information. This should be coordinated with #8470.
Apply:
Depends on #11251
Depends on #11632
CC: @nexttime @nthiery
Component: documentation
Author: Florent Hivert, Minh Van Nguyen
Reviewer: John Palmieri
Merged: sage-4.7.2.alpha4
Issue created by migration from https://trac.sagemath.org/ticket/8886
The text was updated successfully, but these errors were encountered: