-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MPIR: Don't check SAGE_CHECK in spkg-install #9522
Comments
comment:1
There's already a ticket for updating MPIR to version 2.1.1 (currently needing review), which apparently is aware of this ticket. I though haven't checked if Mike deleted the superfluous test suite invocation in |
comment:3
I think there's a good argument for running the mpir test suite every time (i.e. from spkg-install), as it has historically caught several compiler bugs. It's obviously pointless running it twice. Dave |
Reviewer: Leif Leonhardy |
Dependencies: #8664 |
From the end of MPIR's
spkg-install
:We should remove this, since
SAGE_LOCAL/bin/sage-spkg
already does this check:Depends on #8664
Component: packages: standard
Reviewer: Leif Leonhardy
Issue created by migration from https://trac.sagemath.org/ticket/9522
The text was updated successfully, but these errors were encountered: