Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPIR: Don't check SAGE_CHECK in spkg-install #9522

Closed
qed777 mannequin opened this issue Jul 17, 2010 · 5 comments
Closed

MPIR: Don't check SAGE_CHECK in spkg-install #9522

qed777 mannequin opened this issue Jul 17, 2010 · 5 comments

Comments

@qed777
Copy link
Mannequin

qed777 mannequin commented Jul 17, 2010

From the end of MPIR's spkg-install:

if [ "$SAGE_CHECK" = "yes" ]; then
    cd ..; ./spkg-check
fi

We should remove this, since SAGE_LOCAL/bin/sage-spkg already does this check:

    cd $BASEDIR
    if [ "$SAGE_CHECK" != "" -a -f spkg-check ]; then
        echo "Running the test suite."
        chmod +x spkg-check
        ./spkg-check
        if [ $? -ne 0 ]; then

Depends on #8664

Component: packages: standard

Reviewer: Leif Leonhardy

Issue created by migration from https://trac.sagemath.org/ticket/9522

@qed777 qed777 mannequin added this to the sage-4.7.2 milestone Jul 17, 2010
@nexttime
Copy link
Mannequin

nexttime mannequin commented Aug 26, 2010

comment:1

There's already a ticket for updating MPIR to version 2.1.1 (currently needing review), which apparently is aware of this ticket.

I though haven't checked if Mike deleted the superfluous test suite invocation in spkg-install.

@nexttime
Copy link
Mannequin

nexttime mannequin commented Aug 26, 2010

comment:2

Replying to @nexttime:

I though haven't checked if Mike deleted the superfluous test suite invocation in spkg-install.

Done, he did remove it. So this ticket can be closed as duplicate as soon as #8664 gets merged.

@sagetrac-drkirkby
Copy link
Mannequin

sagetrac-drkirkby mannequin commented Sep 21, 2010

comment:3

I think there's a good argument for running the mpir test suite every time (i.e. from spkg-install), as it has historically caught several compiler bugs.

It's obviously pointless running it twice.

Dave

@nexttime
Copy link
Mannequin

nexttime mannequin commented Sep 29, 2011

Reviewer: Leif Leonhardy

@nexttime
Copy link
Mannequin

nexttime mannequin commented Sep 29, 2011

Dependencies: #8664

@nexttime nexttime mannequin removed this from the sage-4.7.2 milestone Sep 29, 2011
@nexttime nexttime mannequin closed this as completed Sep 29, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants