Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for empty string before trying to evaluate in _element_constructor #35610

Merged
merged 3 commits into from
May 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sage/rings/complex_mpfr.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -517,7 +517,7 @@ class ComplexField_class(sage.rings.abc.ComplexField):
x = x.replace('j', 'I')
x = x.replace('E', 'e')
allowed = '+-.*0123456789Ie'
if not all(letter in allowed for letter in x):
if len(x) == 0 or not all(letter in allowed for letter in x):
raise ValueError(f'given string {x!r} is not a complex number')
# This should rather use a proper parser to validate input.
# TODO: this is probably not the best and most
Expand Down
2 changes: 1 addition & 1 deletion src/sage/rings/real_double.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -1522,7 +1522,7 @@ cdef class RealDoubleElement(FieldElement):
def round(self):
"""
Round ``self`` to the nearest integer.

This uses the convention of rounding half to even
(i.e., if the fractional part of ``self`` is `0.5`, then it
is rounded to the nearest even integer).
Expand Down
2 changes: 1 addition & 1 deletion src/sage/rings/real_mpfr.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -2992,7 +2992,7 @@ cdef class RealNumber(sage.structure.element.RingElement):
"""
Round ``self`` to the nearest representable integer, rounding halfway
cases away from zero.

.. NOTE::

The rounding mode of the parent field does not affect the result.
Expand Down