-
-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MPowerSeries
: Don't go through symbolics to compute exp(0), log(1)
#36260
Merged
vbraun
merged 8 commits into
sagemath:develop
from
mkoeppe:mpowerseries_exp_log_trivial
Sep 16, 2023
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
12f6ef8
bootstrap: Use 'ENABLE_SYSTEM_SITE_PACKAGES=yes sage-get-system-packa…
mkoeppe ca94eb4
MPowerSeries.exp: Don't use symbolics to compute exp(0)
mkoeppe eded0e7
MPowerSeries.log: Don't use symbolics to compute log(1)
mkoeppe 5454b51
Merge branch 'fix_bootstrapped_pkg_metadata' into mpowerseries_exp_lo…
mkoeppe 0785206
Update pyproject.toml files to use version info from build/pkgs/setup…
mkoeppe 366725c
Merge branch 'fix_bootstrapped_pkg_metadata' into pyproject_toml_setu…
mkoeppe 7dde129
./sage -fixdoctests --long --distribution 'sagemath-polyhedra[standar…
mkoeppe e2a76d2
Merge branch 'pyproject_toml_setuptools' into mpowerseries_exp_log_tr…
mkoeppe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can avoid
SR
withg.exp()
here and likewise in the other examples.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this error does not come from going through SR but illustrates that exp(2) does not exist in the base ring.
2 of the other
# needs sage.symbolic
turned out to be unnecessary due to advances in modularization. Removed in 7dde129