-
-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement call method for elements in CDGA's #36329
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
dbff04d
Implement call method for elements in CDGA's
miguelmarco cdd4142
Update src/sage/algebras/commutative_dga.py
miguelmarco 396c07a
Update src/sage/algebras/commutative_dga.py
miguelmarco bc1e77d
Update src/sage/algebras/commutative_dga.py
miguelmarco f099194
Update src/sage/algebras/commutative_dga.py
miguelmarco f933f0c
Update src/sage/algebras/commutative_dga.py
miguelmarco 58774c7
Improve documentation
miguelmarco a1d6238
Update src/sage/algebras/commutative_dga.py
miguelmarco 6ffd806
Update src/sage/algebras/commutative_dga.py
miguelmarco 24ef310
Update src/sage/algebras/commutative_dga.py
miguelmarco a1d23b5
Reviewer's comments
miguelmarco 320f177
Merge branch 'eval_cdga' of github.com:miguelmarco/sage into eval_cdga
miguelmarco File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By this point, you have not used/parsed the keywords. So if someone passes in a mixture, then this might give a false result. In general, you probably should at least document the behavior and what you expect to have happen.