Fix regex to remove spurious diffs in doc preview

[kwankyu]

There was an error in the regex, seen in

https://preview-38210--sagemath.netlify.app/changes

Also removed most spurious diffs: see changes of this PR.

📝 Checklist

• The title is concise and informative.
• The description explains in detail what this PR is about.
• I have linked a relevant issue or discussion.
• I have created tests covering the changes.
• I have updated the documentation and checked the documentation preview.

⌛ Dependencies

[github-actions]

Documentation preview for this PR (built with commit d1220c9; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

[mkoeppe]

LGTM, thanks for the fix.

[kwankyu]

Thanks!

[kwankyu]

I am trying to understand where the last diff left in "changes" come from.

"changes" is the result of git diff between the "new" doc built from the branch of this PR and the "old" doc built for the latest release. Hence the "old" doc should be the doc in ghcr.io/sagemath/sage/sage-ubuntu-jammy-standard-with-targets:dev (or 10.4.beta9).

According to this run of doc-build workflow:

https://github.com/sagemath/sage/actions/runs/9500068057/job/26182310478?pr=38213

"Build Docker Image" step builds docker image localhost:5000/sagemath/sage/sage-ubuntu-jammy-standard-with-targets:ci from ghcr.io/sagemath/sage/sage-ubuntu-jammy-standard-with-targets:dev. But then In the next "Start container" step,

docker run --name BUILD -dit \
             --mount type=bind,src=$(pwd),dst=$(pwd) \
             --workdir $(pwd) \
             localhost:[5](https://github.com/sagemath/sage/actions/runs/9500068057/job/26182310478?pr=38213#step:10:5)000/sagemath/sage/sage-ubuntu-jammy-standard-with-targets:ci /bin/sh
  shell: /usr/bin/bash -e {0}
  env:
    TOX_ENV: docker-ubuntu-jammy-standard-incremental
    BUILD_IMAGE: localhost:5000/sagemath/sage/sage-ubuntu-jammy-standard-with-targets:ci
    FROM_DOCKER_REPOSITORY: ghcr.io/sagemath/sage/
    FROM_DOCKER_TARGET: with-targets
    FROM_DOCKER_TAG: dev
    EXTRA_CONFIGURE_ARGS: --enable-fat-binary
Unable to find image 'localhost:5000/sagemath/sage/sage-ubuntu-jammy-standard-with-targets:ci' locally
ci: Pulling from sagemath/sage/sage-ubuntu-jammy-standard-with-targets

it seems that it fails to find the image localhost:5000/sagemath/sage/sage-ubuntu-jammy-standard-with-targets:ci, and instead pull sagemath/sage/sage-ubuntu-jammy-standard-with-targets with no tag. Thus, I think, it pulls the image with the default latest tag. But then according to

https://github.com/sagemath/sage/pkgs/container/sage%2Fsage-ubuntu-jammy-standard-with-targets/versions

sagemath/sage/sage-ubuntu-jammy-standard-with-targets:latest would be 10.3. Hence all screws up... Am I right? This explanation seems still strange since 10.3 is too old version...

[mkoeppe]

The incremental build is always starting from the tag :dev (see FROM_DOCKER_TAG)

[mkoeppe]

Unable to find image 'localhost:5000/sagemath/sage/sage-ubuntu-jammy-standard-with-targets:ci' locally
ci: Pulling from sagemath/sage/sage-ubuntu-jammy-standard-with-targets

This message just means it's pulling what was just built.

[kwankyu]

Ah, I see. So localhost:5000/sagemath/sage/sage-ubuntu-jammy-standard-with-targets:ci is just ghcr.io/sagemath/sage/sage-ubuntu-jammy-standard-with-targets:dev.

I looked into ghcr.io/sagemath/sage/sage-ubuntu-jammy-standard-with-targets:dev, and indeed there are lines:

<span class="go">  --sws2rst &lt;sws doc&gt; -- Generates a reStructuredText source file from</span>
<span class="go">                         a Sage worksheet (.sws) document.</span>
<span class="go">                         (not installed currently, run sage -i sage_sws2rst)</span>

<span class="go">Valgrind memory debugging:</span>

Hence the diff is genuine.

On the other hand, looking into the source file of the page https://sagemath.netlify.app/html/en/reference/repl/options, which was uploaded from localhost:5000/sagemath/sage/sage-ubuntu-jammy-standard-with-targets:ci, I see

<span class="go">  --sws2rst &lt;sws doc&gt; -- Generates a reStructuredText source file from</span>
<span class="go">                         a Sage worksheet (.sws) document.</span>
  
<span class="go">Valgrind memory debugging:</span>

where, as you see, there is no line

<span class="go">                         (not installed currently, run sage -i sage_sws2rst)</span>

!

[kwankyu]

Hmm presently https://sagemath.netlify.app/html/en/reference/repl/options is doc for PR #38205! Strange things are happening...

[kwankyu]

presently https://sagemath.netlify.app/html/en/reference/repl/options is doc for PR #38205!

This is fixed by #38220.