Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Korean translations of a_tour_of_sage and tutorial #38229

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Add Korean translations of a_tour_of_sage and tutorial #38229

wants to merge 1 commit into from

Conversation

kwankyu
Copy link
Collaborator

@kwankyu kwankyu commented Jun 16, 2024

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@kwankyu kwankyu force-pushed the p/korean-translations branch from 0981839 to 8ac8443 Compare June 16, 2024 10:56
@kwankyu kwankyu changed the title Add Korean translations Add Korean translations of a tour of sage and tutorial Jun 16, 2024
@kwankyu kwankyu force-pushed the p/korean-translations branch 2 times, most recently from 5759df9 to 1056092 Compare June 16, 2024 13:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 16, 2024 •
edited
Loading

Documentation preview for this PR (built with commit ecc6a66; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

grhkm21
grhkm21 reviewed Jun 16, 2024
View reviewed changes
src/doc/ko/a_tour_of_sage/index.rst Outdated

::

sage: x = var('x') # δημιουργίας συμβολικής μεταβλητής
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These need changing too :) (I know this is a draft PR, just saying)

Copy link
Collaborator Author

@kwankyu kwankyu Jun 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is a draft yet. Far from complete.

I made these Korean versions using ChatGPT from @gmou3's Greek versions #38109. I will now compare the Korean versions with English versions and make them readable. Along the way, I could "review" the Greek versions :-)

@kwankyu kwankyu changed the title Add Korean translations of a tour of sage and tutorial Add Korean translations of a_tour_of_sage and tutorial Jun 17, 2024
@kwankyu kwankyu force-pushed the p/korean-translations branch from 1056092 to ecc6a66 Compare June 17, 2024 07:36
@gmou3
Copy link
Contributor

gmou3 commented Jun 27, 2024

안녕하세요!
How is work progressing here?

I did consider improving the English documentation in its entirety but it is quite a serious undertaking. No such plans for now.

@kwankyu
Copy link
Collaborator Author

kwankyu commented Jun 27, 2024

안녕하세요!

Γεια σας!

I did consider improving the English documentation in its entirety but it is quite a serious undertaking. No such plans for now.

Yeah, I understand. The English tutorial is not small. We need much time or man-power for this kind of undertaking.

How is work progressing here?

No progress at all now. This is also a serious undertaking that would take a long time to complete.

Though this task is of low priority to me personally, I expect that I could complete this in this year :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grhkm21 grhkm21 grhkm21 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kwankyu @gmou3 @grhkm21