Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write better tests and support for aliases #9

Open
sagikazarmark opened this issue Sep 9, 2019 · 2 comments
Open

Write better tests and support for aliases #9

sagikazarmark opened this issue Sep 9, 2019 · 2 comments
Labels

Comments

@sagikazarmark
Copy link
Owner

No description provided.

@eddiewang
Copy link

eddiewang commented Nov 1, 2020

trying to generate some mga scaffolding via aliased types like so:

// +mga:event:handler
type EvtJournalShareShepard = luxproto.JournalHeader

// +mga:event:handler
type EvtJournalBlockFind = luxproto.JournalHeader

The usecase here is to allow the protobuf definition's themselves to be the event struct that will be passed to watermill in the event dispatcher pattern.

Would love to know if there's any path to take to support that. Currently I am getting the error unknown type <NameOfAliasedType>

Assuming this is related to the feature request here, but let me know if I should create a seperate issue for it.

@sagikazarmark
Copy link
Owner Author

sagikazarmark commented Nov 4, 2020

This issue is related to the event dispatcher generator, but it's actually the same issue for handlers as well.

The problem is that the code generation library (https://github.com/kubernetes-sigs/controller-tools) doesn't work well with aliases and I haven't find a good solution so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants