Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove connect-assets, Switch to Sass, Node.js 4.0 #317

Closed
sahat opened this issue Sep 9, 2015 · 4 comments
Closed

Remove connect-assets, Switch to Sass, Node.js 4.0 #317

sahat opened this issue Sep 9, 2015 · 4 comments

Comments

@sahat
Copy link
Owner

sahat commented Sep 9, 2015

Sass

This project used to have Sass stylesheets at some point but I had to revert it back to Less CSS due to io.js breaking node-sass compatibility with every release. Now that Node.js 4.0 is finally out, I think this is less of an issue.

Interestingly enough, according to this blog post (9/9/2015), Sass is currently a preferred choice for the CSS preprocessor.

Connect Assets

This leads us to connect-assets. I understand its usefulness, but it is also painfully slow and significantly affects start-up time for the application. This becomes an issue when you have to wait 3-5 seconds for your app to restart after making any changes. I would prefer to include sass middleware directly and not worry about automatic minification and concatenation of JS files. While you should always try to minify your assets and reduce number of requests for production-running apps, that's not an issue at all for smaller / hackathon projects.

I am opening this GitHub issue so we could discuss the changes proposed above, but if you like the changes then comment below with +1(:+1:).

@drannex42
Copy link

👍 Let's do it!

@reesretuta
Copy link
Contributor

👍

@chrisvdb
Copy link

  • sass: +1
  • connect-assets: the increased startup time is somewhat annoying but I would definitely miss the convenience...

@sahat
Copy link
Owner Author

sahat commented Sep 26, 2015

Load time with connect-assets
screenshot 2015-09-25 18 03 37

Load time without connect-assets
screenshot 2015-09-25 18 03 27

I would imagine the load time will again go up slightly after I add LESS or Sass stand-alone middleware, but still that's a pretty significant difference.

Update

More or less consistent ~1600ms with the Sass middleware. Around ~1800ms when comping Sass files for the first time.

screenshot 2015-09-25 18 22 43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants