Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce cyclomatic complexity #120

Open
turgeonmaxime opened this issue Jun 23, 2020 · 0 comments
Open

reduce cyclomatic complexity #120

turgeonmaxime opened this issue Jun 23, 2020 · 0 comments

Comments

@turgeonmaxime
Copy link
Collaborator

I ran lintr on our package, and three functions were flagged as having high cyclomatic complexity:

  • casebase::absoluteRisk
  • casebase::absoluteRisk.CompRisk
  • casebase::fitSmoothHazard

Since high cyclomatic complexity means that it's harder to maintain the code (because it's more difficult to reason about it), it may be worth refactoring the code of these functions to decrease this complexity. This is definitely not urgent, but I thought I would flag it in case someone wants to have a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant