Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make configuration in local.js match config/mail.js #17

Closed
1 of 2 tasks
DominusKelvin opened this issue Mar 18, 2024 · 0 comments · Fixed by #18
Closed
1 of 2 tasks

Make configuration in local.js match config/mail.js #17

DominusKelvin opened this issue Mar 18, 2024 · 0 comments · Fixed by #18

Comments

@DominusKelvin
Copy link
Member

DominusKelvin commented Mar 18, 2024

Since configs in locals.js gets merged into other configs, it makes more sense not to deviate from how mailers are being configured in config/mail.js. Currently we have:

mailer: 'nodemailer',
mailer: {
   nodemailer: {}
}

But we can however follow same configuration signature in config/mail.js and eliminate the checks in getting what mailer to use in production or development all together. With this change setting up an email mailer in local will look similar to that in config/mails.js.

mail: {
 default: 'nodemailer',
 mailers: {
    nodemailer: {}
}
}

This simplifies things.

  • update code to reflect this decision
  • update docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant