アセンブラ出力を行い、artifacts に含める #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
文字コード変換によるデグレがないことを検証することが |
berryzplus
reviewed
Jul 21, 2018
| @@ -105,6 +105,7 @@ | |||
| <DebugInformationFormat>ProgramDatabase</DebugInformationFormat> | |||
| <AdditionalOptions>/source-charset:shift_jis %(AdditionalOptions)</AdditionalOptions> | |||
| <MultiProcessorCompilation>true</MultiProcessorCompilation> | |||
| <AssemblerOutput>AssemblyAndSourceCode</AssemblerOutput> | |||
There was a problem hiding this comment.
お疲れ様です。1件お願いです。
アセンブラリストの出力にUnicodeを使う、というオプションが存在するので、それも一緒に入れたいです。
#264 (comment) ←このコメントでも書いてますが。
There was a problem hiding this comment.
今 pc 環境がないので、2日後に確認します。
There was a problem hiding this comment.
アセンブラリストの出力にUnicodeを使う、というオプションが存在するので、それも一緒に入れたいです。
これを入れると、もともとのソースコードが含まれなくなるみたいだ。
There was a problem hiding this comment.
↑ サイズが半減する。(圧縮後のサイズで 5 MB → 3MB)
|
ご対応ありがとうございます。明日あたりUTF系PRのrebaseやっておきます |
This was referenced Jul 24, 2018
This was referenced Jul 24, 2018
This was referenced Jul 24, 2018
Closed
takke
added a commit
to takke/sakura
that referenced
this pull request
Apr 3, 2019
HoppingTappy
pushed a commit
to HoppingTappy/sakura
that referenced
this pull request
Jun 11, 2019
アセンブラ出力を行い、artifacts に含める
HoppingTappy
pushed a commit
to HoppingTappy/sakura
that referenced
this pull request
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#286: アセンブラ出力を行い、artifacts に含める
コンパイラの設定でオブジェクトファイルの生成と同時にアセンブラ出力も行う。