Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cppcheck で -j オプションを指定して同時に複数のチェックを行う #376

Merged

Conversation

m-tmatma
Copy link
Member

@m-tmatma m-tmatma commented Aug 26, 2018

#373: -j オプションを指定して同時に複数のチェックを行う

-j <jobs> Start <jobs> threads to do the checking simultaneously.

ローカルで 3分2秒かかっていたものが 1分24秒になった。

C:\sakura-cppcheck>echo %NUMBER_OF_PROCESSORS%
4

@m-tmatma m-tmatma added CI appveyor など CI 関連 【ChangeLog除外】 🚅 speed up 🚀 高速化 cppcheck labels Aug 26, 2018
@m-tmatma m-tmatma added this to the next release milestone Aug 26, 2018
@m-tmatma m-tmatma force-pushed the feature/run-cppcheck-simultaneously branch from 338bf8e to afccdfb Compare August 28, 2018 08:19
Copy link
Contributor

@berryzplus berryzplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです。

@@ -49,6 +49,7 @@ set CPPCHECK_PARAMS=%CPPCHECK_PARAMS% --enable=all
set CPPCHECK_PARAMS=%CPPCHECK_PARAMS% --xml
set CPPCHECK_PARAMS=%CPPCHECK_PARAMS% --platform=%CPPCHECK_PLATFORM%
set CPPCHECK_PARAMS=%CPPCHECK_PARAMS% --output-file=%CPPCHECK_OUT%
set CPPCHECK_PARAMS=%CPPCHECK_PARAMS% -j %NUMBER_OF_PROCESSORS%
Copy link
Contributor

@berryzplus berryzplus Aug 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ただのコメントですが。

パラメータの行を分けたことにより、何が増えたか一目瞭然になった気がします。
反面、実行部分(58行目)が視界に入らないと何の変数か確信が持てなかったりします。
一長一短ですね。

変更内容は問題ないと判断します。

@m-tmatma m-tmatma merged commit 4c58aeb into sakura-editor:master Aug 28, 2018
@ds14050 ds14050 added CI appveyor など CI 関連 【ChangeLog除外】 🚅 speed up 🚀 高速化 cppcheck labels Sep 18, 2018
HoppingTappy pushed a commit to HoppingTappy/sakura that referenced this pull request Jun 11, 2019
…ck-simultaneously

cppcheck で -j オプションを指定して同時に複数のチェックを行う
@m-tmatma m-tmatma deleted the feature/run-cppcheck-simultaneously branch July 5, 2019 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚅 speed up 🚀 高速化 CI appveyor など CI 関連 【ChangeLog除外】 cppcheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants