Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite in Erlang #3

Closed
tsloughter opened this issue Sep 20, 2021 · 2 comments · Fixed by #4
Closed

Rewrite in Erlang #3

tsloughter opened this issue Sep 20, 2021 · 2 comments · Fixed by #4

Comments

@tsloughter
Copy link

Since Elixir 1.10 both Elixir and Erlang share the same logger metadata. Meaning if this project were instead in Erlang it could be easily used in projects in any beam based language :)

We probably also want to have this in OpenTelemetry core, so maybe consider a PR to OpenTelemetry itself.

@indrekj
Copy link
Member

indrekj commented Sep 21, 2021

Since Elixir 1.10 both Elixir and Erlang share the same logger metadata. Meaning if this project were instead in Erlang it could be easily used in projects in any beam based language :)

Yup, indeed. I wrote this to get something quickly running and to test it out (though I have not deployed this anywhere just yet). It should be quite straightforward to write it in Erlang (even more after open-telemetry/opentelemetry-erlang#270 get merged/released).

We probably also want to have this in OpenTelemetry core, so maybe consider a PR to OpenTelemetry itself.

I thought about this as well but wasn't really sure how to approach this (i.e. where it should live and how it should be set up).

@indrekj
Copy link
Member

indrekj commented Sep 24, 2021

@tsloughter I created #4 . Please feel free to review it. My erlang experience is minimal but I think that should work. At least a couple of my manual tests worked and it also worked through Elixir.

@indrekj indrekj closed this as completed Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants