Migrate product page to new macaw #4125

poulch · 2023-08-25T08:15:45Z

AC:

Product details page should contain only inputs from new Macaw
Combobox and multiselect inputs should support infinity-loading items
Combobox and multiselect inputs in Attributes should also support custom values for inputs
Metadata should not show an empty table when there are no metadata
Metadata should show an Empty string when there are no metadata
PriceField component uses input from the new Macaw (uses in RefundCard, OrderManualTransationForm, RefundAmountInput, TransactionCard,
SeoForm use accordion component from new Macaw, and should show completed/incompleted status message
Remove Variant currently in preorder section (including ProductVariant page) ✔️

Screenshots

Pull Request Checklist

This code contains UI changes
All visible strings are translated with proper context including data-formatting
Attributes data-test-id are added for new elements
The changes are tested in Chrome/Firefox/Safari browsers and in light/dark mode
Your code works with the latest stable version of the core
I added changesets and read good practices

Test environment config

API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps

Do you want to run more stable tests?

To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.

CONTAINERS=6

changeset-bot · 2023-08-25T08:15:48Z

🦋 Changeset detected

Latest commit: aa7f9e7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
saleor-dashboard	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

src/components/Attributes/SwatchRow.tsx

src/products/components/ProductOrganization/ProductOrganization.tsx

src/products/components/ProductTaxes/ProductTaxes.tsx

src/components/Attributes/BasicAttributeRow.tsx

src/components/Combobox/Combobox.tsx

src/components/Metadata/MetadataCard.tsx

src/components/Multiselect/Multiselect.tsx

wojteknowacki · 2023-09-12T12:50:21Z

When metadata text is large field inputs shrinks to none readable size

wojteknowacki · 2023-09-12T13:12:30Z

Opened taxes with multi-available channels stretch UI

wojteknowacki · 2023-09-12T13:35:03Z

Price input is cleared when the price uses a format with dot - 23.23

Nagranie.z.ekranu.2023-09-12.o.15.32.02.mov

Co-authored-by: timur <timuric@gmail.com>

* Strict TS adjustments * Add datagrid to shipping zones list * Support for bulk delete * Extract messages * Add changeset * Cleanup * Fix stories & fixtures * Fix freeze columns * Replace params.ids with selectedRowIds * Implement search & relocate bulk delete button * Unify margins * Move default weight unit form to TopNav.Menu * Add weight configuration modal * Fix type issue * Add messages * Fix strict mode * Simplify modal closing * Disable dialog when incorrect unit is selected * Move outside render * Disable pricerange column * e2e fixes * Replace combobox with select * shipping method test - remove wait for skeleton * Update macaw-ui * Skip cypress cloud when running e2e tests (#4162) * wip * cr fixes --------- Co-authored-by: Paweł Chyła <pawel.chyla@saleor.io> * Update vite sentry library and handle legacy uploading (#4169) * Handle legacy sentry * Changeset * Increate memory for vite sourcemaps (sentry) (#4173) * Increate memory for vite sourcemaps (sentry) * Changeset * Remove legacy sentry * Use sentry cli (#4175) * use sentry cli * use sentry cli * use sentry cli * Fix rendering of top products on home, when attributes does not have value (#4172) * Fix top product on home * Fix top product on home * Changeset * Fix attribute creation when we change input type (#4177) * Fix attribute creation * Fix attribute creation * Fix layouts for translation edition pages (#4178) * Fix translation pages * Fix translation pages * Update changesets based deployments (#4167) * 3.15.3 release cleanup (#4180) * Fix address form keeps country state from prev address provided (#4188) * Fixes Dashboard crash on quick-menu escape (#4166) * crash-fix#3933 * Update changesets based deployments * Added sk translation (#4144) * Added sk translation * add changeset for SK translation --------- Co-authored-by: Ladislav Hano <524934@mail.muni.cz> * Migrate product page to new macaw (#4125) Co-authored-by: timur <timuric@gmail.com> * Dashboard modal (#4198) * Datagrid cell improvements (#4091) * Implement status cell * Add auto tags cell * Tighten types * Redesign money cell * Add light text color * Add custom date cell * Add color difference * Remove moment * Make font bolder * Add range price * Switch to new date cell * Made font heavier * Make image bigger * Use tag cells * Fixed lint errors * Add percentage display * Fix type errors * Add safety check * Add safety check * Remove duplicate * Enable darkmode support * Fix linter issue * Refactor date cell * Refactor money cell * Rename AutoTags cell to PillCell * TS cleanup * Add changeset * Fix strict mode * Strict TS fixes * Tune dark mode colors * Add fallback for oklch * Fix date cell * Fix tests after oklch fallback is added * Add type - strict mode fix * Reading channel * Conditionally set selected channel based on feature flag * Fix currency crash * Obtain channel * Cleanup * Fix test * Validate date cell * Fix passing incorrect date in order list * Fix invisible dates * Make default width of date column larger on product and order views --------- Co-authored-by: timur <timuric@gmail.com> Co-authored-by: andrzejewsky <vox3r69@gmail.com> * Update release workflow (#4187) * Update relase workflow * Workflow update * Changesets * Ubuntu version * Aws actions update * Add triage status (#4200) * Bug triage * Bug triage * Triage status * Bump @adobe/css-tools from 4.0.1 to 4.3.1 (#4145) Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.0.1 to 4.3.1. - [Changelog](https://github.com/adobe/css-tools/blob/main/History.md) - [Commits](https://github.com/adobe/css-tools/commits) --- updated-dependencies: - dependency-name: "@adobe/css-tools" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fixed inconsistent capitalization on translation page (#4160) * add_voucher_used-info#3972 (#4161) * add_voucher_used-info#3972 * suggested-update_voucher-used * Epics template (#4202) * Add epic template * Add epic template * Add epic template * Improve text * Fix external app crashing (#4205) * Fix external app crashing * Fix external app crashing * Bump tough-cookie and @cypress/request (#4069) * Bump tough-cookie and @cypress/request Bumps [tough-cookie](https://github.com/salesforce/tough-cookie) and [@cypress/request](https://github.com/cypress-io/request). These dependencies needed to be updated together. Updates `tough-cookie` from 2.5.0 to 4.1.3 - [Release notes](https://github.com/salesforce/tough-cookie/releases) - [Changelog](https://github.com/salesforce/tough-cookie/blob/master/CHANGELOG.md) - [Commits](salesforce/tough-cookie@v2.5.0...v4.1.3) Updates `@cypress/request` from 2.88.11 to 2.88.12 - [Release notes](https://github.com/cypress-io/request/releases) - [Changelog](https://github.com/cypress-io/request/blob/master/CHANGELOG.md) - [Commits](cypress-io/request@v2.88.11...v2.88.12) --- updated-dependencies: - dependency-name: tough-cookie dependency-type: indirect - dependency-name: "@cypress/request" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * Trigger CI --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: andrzejewsky <vox3r69@gmail.com> * Fix prepare release workflow dependency (#4207) * Fix workflow * Fix workflow * Handle null * Refactor modal * Change as to satisfies --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: wojteknowacki <wojciech.nowacki@saleor.io> Co-authored-by: wojteknowacki <124166231+wojteknowacki@users.noreply.github.com> Co-authored-by: Paweł Chyła <pawel.chyla@saleor.io> Co-authored-by: Patryk Andrzejewski <vox3r69@gmail.com> Co-authored-by: Krzysztof Żuraw <9116238+krzysztofzuraw@users.noreply.github.com> Co-authored-by: Paweł Chyła <chyla1988@gmail.com> Co-authored-by: Rishi Jain <itsjainrishi@users.noreply.github.com> Co-authored-by: Djkáťo <radovan.katrencik@gmail.com> Co-authored-by: Ladislav Hano <524934@mail.muni.cz> Co-authored-by: timur <timuric@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tushar Rathore <tushh.r1212@gmail.com>

poulch added 12 commits August 22, 2023 22:41

Bump macaw

12d6034

WIP Attributes in product page

d59e9b1

Bump macaw ui

b6715cf

Implement swatch row

15057ff

Use DynamicMultiselect in Attributes

c414f93

Add label to swatch row

a4dce26

Bump macaw to 123

e27a055

Add textarea to metadata and seo

4502995

Fix debounce import

7f487af

bump macaw to 124

4b8b01c

Add rest of new fields

edcde24

Update PriceField input

af97336

poulch added 2 commits August 25, 2023 10:17

Merge branch 'main' into 4009-migrate-product-page

dc4ec48

Add changeset

b9b8d1f

github-actions bot temporarily deployed to 4009-migrate-product-page August 25, 2023 08:19 Inactive

github-actions bot temporarily deployed to storybook 4009-migrate-product-page August 25, 2023 08:19 Inactive

poulch added 3 commits August 25, 2023 13:31

bump macaw 125

642511f

Fix attribute dropdown combobox

aee88c1

Update rich text styles

49c38a3

poulch marked this pull request as ready for review August 28, 2023 08:41

poulch requested review from a team, andrzejewsky and Droniu August 28, 2023 08:41

poulch added 2 commits August 28, 2023 11:54

Bump macaw 127

ec7dc40

Fix combobox and multiselect in

b541ec6

Droniu reviewed Aug 28, 2023

View reviewed changes

Fix types

d5c357e

github-actions bot temporarily deployed to 4009-migrate-product-page August 29, 2023 08:01 Inactive

github-actions bot temporarily deployed to storybook 4009-migrate-product-page August 29, 2023 08:01 Inactive

andrzejewsky requested changes Sep 8, 2023

View reviewed changes

poulch added 2 commits September 8, 2023 20:31

Remove lodash import and use typeof

a4c8888

Refactor multiselect and combobox

2f49ae0

github-actions bot temporarily deployed to 4009-migrate-product-page September 11, 2023 08:06 Destroyed

github-actions bot temporarily deployed to storybook 4009-migrate-product-page September 11, 2023 08:06 Destroyed

poulch requested review from Droniu and andrzejewsky September 11, 2023 08:06

andrzejewsky previously approved these changes Sep 12, 2023

View reviewed changes

Droniu previously approved these changes Sep 12, 2023

View reviewed changes

Addd space to open product taxes dropdown

2044c72

poulch dismissed stale reviews from Droniu and andrzejewsky via 2044c72 September 13, 2023 09:36

github-actions bot temporarily deployed to 4009-migrate-product-page September 13, 2023 09:36 Destroyed

github-actions bot temporarily deployed to storybook 4009-migrate-product-page September 13, 2023 09:36 Destroyed

poulch added 2 commits September 14, 2023 11:03

Merge branch 'main' into 4009-migrate-product-page

948fa2c

Bump macaw and add padding

aa7f9e7

github-actions bot temporarily deployed to 4009-migrate-product-page September 15, 2023 08:19 Destroyed

github-actions bot deployed to storybook 4009-migrate-product-page September 15, 2023 08:19 View deployment

wojteknowacki self-requested a review September 15, 2023 11:21

wojteknowacki approved these changes Sep 15, 2023

View reviewed changes

Droniu approved these changes Sep 15, 2023

View reviewed changes

poulch merged commit 0dd785b into main Sep 15, 2023
16 of 18 checks passed

poulch deleted the 4009-migrate-product-page branch September 15, 2023 11:43

Droniu pushed a commit that referenced this pull request Sep 19, 2023

Migrate product page to new macaw (#4125)

77ed558

Co-authored-by: timur <timuric@gmail.com>

poulch restored the 4009-migrate-product-page branch July 1, 2024 11:26

poulch deleted the 4009-migrate-product-page branch July 1, 2024 11:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate product page to new macaw #4125

Migrate product page to new macaw #4125

poulch commented Aug 25, 2023 •

edited by wojteknowacki

Loading

changeset-bot bot commented Aug 25, 2023 •

edited

Loading

wojteknowacki commented Sep 12, 2023

wojteknowacki commented Sep 12, 2023

wojteknowacki commented Sep 12, 2023

Migrate product page to new macaw #4125

Migrate product page to new macaw #4125

Conversation

poulch commented Aug 25, 2023 • edited by wojteknowacki Loading

Screenshots

Pull Request Checklist

Test environment config

Do you want to run more stable tests?

changeset-bot bot commented Aug 25, 2023 • edited Loading

🦋 Changeset detected

wojteknowacki commented Sep 12, 2023

wojteknowacki commented Sep 12, 2023

wojteknowacki commented Sep 12, 2023

poulch commented Aug 25, 2023 •

edited by wojteknowacki

Loading

changeset-bot bot commented Aug 25, 2023 •

edited

Loading