Fix pasting float number into datagrid #4335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 27bb5ed The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
temporarily deployed
to
storybook 2882-fix-pasting-price
github-actions
bot
temporarily deployed
to
storybook 2882-fix-pasting-price
github-actions
bot
temporarily deployed
to
storybook 2882-fix-pasting-price
andrzejewsky
approved these changes
Oct 17, 2023
Droniu
approved these changes
Oct 17, 2023
github-actions
bot
temporarily deployed
to
storybook 2882-fix-pasting-price
github-actions
bot
temporarily deployed
to
storybook 2882-fix-pasting-price
Cloud11PL
reviewed
Apr 19, 2024
Comment on lines
+85
to
+88
| const testRegExp = data.options?.hasFloatingPoint | ||
| ? flaotingPointDigits | ||
| : onlyDigitsRegExp; | ||
| if (!testRegExp.test(value)) { |
There was a problem hiding this comment.
Question: It causes copy/paste issues if value is below 10 or doesn't have ".x". hasFloatingPoint is set to true for all number cells. Was there a requirement why this test was made like that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this because it fix problem with pasting floating-point price in product variant datagrid
Screenshots
Pull Request Checklist
data-test-idare added for new elementsTest environment config
API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps
Do you want to run more stable tests?
To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.
CONTAINERS=6