Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change assertion text within channels checkbox in e2e tests #4585

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

wojteknowacki
Copy link
Member

@wojteknowacki wojteknowacki commented Jan 3, 2024

Copy for assertion was to detailed - contained number of channels in DB.

Screenshots

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes data-test-id are added for new elements
  4. The changes are tested in Chrome/Firefox/Safari browsers and in light/dark mode
  5. Your code works with the latest stable version of the core
  6. I added changesets file (instructions in contribution guide

Test environment config

API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps

Do you want to run more stable tests?

To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.

  1. stable
  2. app
  3. attribute
  4. category
  5. collection
  6. customer
  7. giftCard
  8. homePage
  9. login
  10. menuNavigation
  11. navigation
  12. orders
  13. pages
  14. payments
  15. permissions
  16. plugins
  17. productType
  18. products
  19. sales
  20. shipping
  21. translations
  22. variants
  23. vouchers

CONTAINERS=2

@wojteknowacki wojteknowacki requested review from a team, andrzejewsky and Droniu January 3, 2024 09:56
Copy link

changeset-bot bot commented Jan 3, 2024

🦋 Changeset detected

Latest commit: a4d9ad1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pr-fix-copy-e2e-tests January 3, 2024 09:57 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-fix-copy-e2e-tests January 3, 2024 09:57 Destroyed
@wojteknowacki wojteknowacki added this to the Saleor 3.19 milestone Jan 3, 2024
@wojteknowacki wojteknowacki changed the title Copy fix in e2e tests Change assertion text within channels checkbox in e2e tests Jan 3, 2024
@wojteknowacki wojteknowacki merged commit 3b9f4ee into main Jan 3, 2024
17 checks passed
@wojteknowacki wojteknowacki deleted the fix-copy-e2e-tests branch January 3, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👀 In Review
Development

Successfully merging this pull request may close these issues.

3 participants