Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove base price from dashboard #555

Merged
merged 25 commits into from
Jun 19, 2020
Merged

Conversation

orzechdev
Copy link
Contributor

@orzechdev orzechdev commented Jun 8, 2020

I want to merge this change because it

  • migrates product base price to gross price from priceRangeUndiscounted in the product list and category product list
  • removes base price usage from product create and product update page
  • removes base price usage from product variant creator

PR intended to be tested with API branch:

Screenshots

Zrzut ekranu 2020-06-16 o 18 54 29

Zrzut ekranu 2020-06-16 o 18 55 20

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@orzechdev orzechdev changed the title Remove base price from product create page Remove base price from dashboard Jun 16, 2020
src/categories/queries.ts Outdated Show resolved Hide resolved
src/categories/queries.ts Outdated Show resolved Hide resolved
src/products/components/ProductList/ProductList.tsx Outdated Show resolved Hide resolved
src/products/components/ProductList/ProductList.tsx Outdated Show resolved Hide resolved
src/products/components/ProductListPage/utils.ts Outdated Show resolved Hide resolved
src/products/queries.ts Outdated Show resolved Hide resolved
src/products/queries.ts Outdated Show resolved Hide resolved
src/products/queries.ts Outdated Show resolved Hide resolved
locale/defaultMessages.json Show resolved Hide resolved
locale/defaultMessages.json Show resolved Hide resolved
src/products/components/ProductList/ProductList.tsx Outdated Show resolved Hide resolved
src/categories/queries.ts Outdated Show resolved Hide resolved
@orzechdev orzechdev merged commit 4b85cf4 into master Jun 19, 2020
@orzechdev orzechdev deleted the feature/remove-base-price branch June 19, 2020 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants