Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move fragments to separate directory to avoid circular imports #592

Merged
merged 2 commits into from
Jul 7, 2020
Merged

Move fragments to separate directory to avoid circular imports #592

merged 2 commits into from
Jul 7, 2020

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because jest can't into circular imports.
Didn't change anything when it comes to functionality, just imports.

PR intended to be tested with API branch: master

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@dominik-zeglen dominik-zeglen merged commit 3d91ca1 into master Jul 7, 2020
@dominik-zeglen dominik-zeglen deleted the ref/separate-fragments branch July 7, 2020 15:21
@orzechdev orzechdev mentioned this pull request Jul 8, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orzechdev orzechdev orzechdev approved these changes

@AlicjaSzu AlicjaSzu Awaiting requested review from AlicjaSzu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dominik-zeglen @orzechdev