Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing save button #636

Merged
merged 2 commits into from
Aug 12, 2020
Merged

Fix missing save button #636

merged 2 commits into from
Aug 12, 2020

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it fixes disappearing "save filters" button on the product list (and sales and vouchers too).

PR intended to be tested with API branch: master

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Data-test are added for new elements.
  7. Type definitions are up to date.
  8. Changes are mentioned in the changelog.

Test environment config

API_URI=https://master.staging.saleor.rocks/graphql/

@github-actions github-actions bot temporarily deployed to fix-filter-saving August 10, 2020 15:35 Inactive
@patrys
Copy link
Member

patrys commented Aug 10, 2020

Task linked: CU-62mtyk Filters cannot be saved

@github-actions github-actions bot temporarily deployed to fix-filter-saving August 10, 2020 15:36 Inactive
@github-actions github-actions bot temporarily deployed to fix-filter-saving August 12, 2020 10:49 Inactive
@dominik-zeglen dominik-zeglen merged commit c0e0abc into master Aug 12, 2020
@dominik-zeglen dominik-zeglen deleted the fix/filter-saving branch August 12, 2020 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants