Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix user avatars #639

Merged
merged 5 commits into from
Aug 12, 2020
Merged

Fix user avatars #639

merged 5 commits into from
Aug 12, 2020

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it fixes vertical align of user initials in avatars.

Note: build on top of #638

PR intended to be tested with API branch: master

Screenshots

Screenshot 2020-08-11 at 13 18 02

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Data-test are added for new elements.
  7. Type definitions are up to date.
  8. Changes are mentioned in the changelog.

Test environment config

API_URI=https://master.staging.saleor.rocks/graphql/

@github-actions github-actions bot temporarily deployed to fix-user-avatars August 11, 2020 12:32 Inactive
@github-actions github-actions bot temporarily deployed to fix-user-avatars August 11, 2020 12:33 Inactive
krzysztofwolski
krzysztofwolski reviewed Aug 12, 2020
View reviewed changes
schema.graphql Outdated Show resolved Hide resolved
@patrys
Copy link
Member

patrys commented Aug 12, 2020

Task linked: CU-74uyc2 Fix rendering staff avatars

@github-actions github-actions bot temporarily deployed to fix-user-avatars August 12, 2020 12:56 Inactive
@dominik-zeglen dominik-zeglen merged commit 63376fc into master Aug 12, 2020
@dominik-zeglen dominik-zeglen deleted the fix/user-avatars branch August 12, 2020 13:48
@krzysztofwolski krzysztofwolski mentioned this pull request Nov 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlicjaSzu AlicjaSzu AlicjaSzu approved these changes

@krzysztofwolski krzysztofwolski krzysztofwolski approved these changes

@orzechdev orzechdev Awaiting requested review from orzechdev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dominik-zeglen @patrys @krzysztofwolski @AlicjaSzu