-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Legacy] Fix #319 - Prevent css sanitization #320
base: hotfix
Are you sure you want to change the base?
[Legacy] Fix #319 - Prevent css sanitization #320
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hey @yunusyerli1 I've tried to test this PR, but I think I need further information as I'm not sure I understand the intent/fix. I've applied your PR and added the suggested to vardefs, ie: However, I cannot see any changes to either a WYSIWYG or HTML field that i've added to the Accounts module. The "How to Test" on this PR, (as well as the Bug related to this PR), appear to be referring to already exisiting custom functionality. Would you be able to provide some steps to test this PR that would be applicable to a generic CRM environment? Thanks! |
Hey @yunusyerli1 I've had a further look into this and it appears as though the trustHTML functionality may be missing from this branch Could you have another look at this, when you get a chance? Thanks! |
aa47ba3
to
41c878e
Compare
Description
Add purifyHtml variable in SugarBean.php and get the value from $def['metadata']['purifyHtml']. #319
Motivation and Context
Whenever you save a Case and change tabs in detail view, CSS of the related fileds was disappearing.
How To Test This
If you add new fields like Property History and if these fields are getting CSS styles:
'metadata' => [
'trustHTML' => true,
'purifyHtml' => false
],
Types of changes
Final checklist