Some SQL queries are not supported in MSSQL

[MilanRaval]

Issue

Some SQL queries are not supported in MSSQL. Noticed below issues so far...

• Backticks(`)
• LIMIT 1 is not supported in MSSQL
• Method "EXTRACT(MONTH FROM" is not supported in MSSQL
• Method 'YEAR(YEAR FROM is not supported in MSSQL

Possible Fix

As a work around fixed the issues by modifying function "query" in MssqlManager.php and SqlsrvManager.php to replace the keywords with keywords supported in MSSQL, and replace backticks(`) with empty string

$sql = str_replace("`", "", $sql);
$sql = str_replace('LIMIT 1', 'TOP 1', $sql);
$sql = str_replace('EXTRACT(MONTH FROM', 'MONTH(', $sql);
$sql = str_replace('YEAR(YEAR FROM', 'YEAR(', $sql);

Steps to Reproduce the Issue

When SuiteCRM is configured to use MSSQL as a database.

Context

Upgrade SuiteCRM from 8.2.1 to 8.6.1

Version

8.6.1

What browser are you currently using?

Chrome

Browser Version

Version 127.0.6533.120 (Official Build) (64-bit)

Environment Information

PHP 8.2

Operating System and Version

Windows

[chris001]

Nice fix. This needs a pull request.